ScopeSim IMG interface #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Great work, @gotten! Thanks for updating to the latest HEEPS and ScopeSim versions. One note: you've added around 100 lines to Could you make this change before I merge the PR? |
Collaborator
|
Hi Gilles ! It might be a good time to revisit this PR. Note that I have updated the package versions dependencies to reflect what my current setup is (in particular the VIP package), which might make heeps and scopesim integration easier. We can follow this here or through emails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update uses the latest HEEPS and Scopesim Versions. Tested working with the package versions mentioned in the README
There are likely a few inconsistencies remaining in the simheeps code but it would be good to merge this version. Inconsistencies related to hardcoded things that should be conf parameters. It doesn't contain any breaking changes to HEEPS itself.