Skip to content

Adds annotations on service #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds annotations on service #40

wants to merge 2 commits into from

Conversation

@DeLoWaN
Copy link

@DeLoWaN DeLoWaN commented Nov 7, 2023

This PR adds annotations on service.

This is useful if you want, for example, to create DNS records with external DNS:

service:
  type: LoadBalancer
  port: 9090
  annotations:
    external-dns.alpha.kubernetes.io/hostname: <URL>

@DeLoWaN DeLoWaN mentioned this pull request Nov 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@afares-hims afares-hims afares-hims approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DeLoWaN @afares-hims