Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compare images to latest #38

Merged
merged 10 commits into from
Aug 23, 2024
Merged

feat: compare images to latest #38

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
359f95a
feat: compare images to latest
rwaffen Aug 22, 2024
e4b3415
fix: compare to general tags
rwaffen Aug 22, 2024
3edf7b5
fix: replace - with :
rwaffen Aug 22, 2024
502a5cf
fix: test unchanged
rwaffen Aug 22, 2024
94d0ef2
fix: do not run on main branch
rwaffen Aug 23, 2024
d5982b5
fix: change naming and taggings
rwaffen Aug 23, 2024
f9145d3
feat: add recommendations and keep old comments
rwaffen Aug 23, 2024
1dbee06
fix: change container name also in tests
rwaffen Aug 23, 2024
190107b
fix: scan for cves without comment and only publish compare result
rwaffen Aug 23, 2024
62b1100
fix: remove sarif from compare
rwaffen Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ on:
pull_request:
branches:
- main
push:
branches:
- main
workflow_dispatch:

jobs:
Expand Down Expand Up @@ -40,7 +37,7 @@ jobs:
- name: Build image
uses: docker/build-push-action@v6
with:
tags: 'ci/voxbox-${{ matrix.rubygem_puppet }}:${{ github.sha }}'
tags: 'ci/voxbox:${{ matrix.rubygem_puppet }}'
push: false
build-args: |
BASE_IMAGE=${{ matrix.base_image }}
Expand All @@ -59,14 +56,24 @@ jobs:
username: voxpupulibot
password: ${{ secrets.DOCKERHUB_BOT_PASSWORD }}

- name: Analyze for critical and high CVEs
id: docker-scout-cves
- name: Analyze container image for CVEs
id: analyze-image-cves
uses: docker/scout-action@v1
with:
command: cves
image: 'local://ci/voxbox-${{ matrix.rubygem_puppet }}:${{ github.sha }}'
image: 'local://ci/voxbox:${{ matrix.rubygem_puppet }}'
sarif-file: sarif.output.${{ matrix.rubygem_puppet }}.${{ github.sha }}.json
write-comment: false

- name: Compare container image to latest from Registry
id: compare-image
uses: docker/scout-action@v1
with:
command: compare
image: 'local://ci/voxbox:${{ matrix.rubygem_puppet }}'
to: 'ghcr.io/voxpupuli/voxbox:${{ matrix.puppet_release }}-main'
summary: true
keep-previous-comments: true

- name: Upload SARIF result
id: upload-sarif
Expand All @@ -81,15 +88,15 @@ jobs:

- name: Test container
run: |
docker run --rm -v $(pwd):/repo ci/voxbox-${{ matrix.rubygem_puppet }}:${{ github.sha }} -f /Rakefile -T
docker run --rm -v $(pwd):/repo ci/voxbox-${{ matrix.rubygem_puppet }}:${{ github.sha }} -f /Rakefile lint
docker run --rm -v $(pwd):/repo ci/voxbox-${{ matrix.rubygem_puppet }}:${{ github.sha }} -f /Rakefile metadata_lint
docker run --rm -v $(pwd):/repo ci/voxbox-${{ matrix.rubygem_puppet }}:${{ github.sha }} -f /Rakefile strings:validate:reference
docker run --rm -v $(pwd):/repo ci/voxbox-${{ matrix.rubygem_puppet }}:${{ github.sha }} -f /Rakefile rubocop
docker run --rm -v $(pwd):/repo ci/voxbox-${{ matrix.rubygem_puppet }}:${{ github.sha }} -f /Rakefile syntax
docker run --rm -v $(pwd):/repo ci/voxbox-${{ matrix.rubygem_puppet }}:${{ github.sha }} -f /Rakefile spec
docker run --rm -v $(pwd):/repo ci/voxbox-${{ matrix.rubygem_puppet }}:${{ github.sha }} -f /Rakefile r10k:syntax
docker run --rm -v $(pwd):/repo ci/voxbox-${{ matrix.rubygem_puppet }}:${{ github.sha }} -f /Rakefile r10k:dependencies
docker run --rm -v $(pwd):/repo ci/voxbox:${{ matrix.rubygem_puppet }} -f /Rakefile -T
docker run --rm -v $(pwd):/repo ci/voxbox:${{ matrix.rubygem_puppet }} -f /Rakefile lint
docker run --rm -v $(pwd):/repo ci/voxbox:${{ matrix.rubygem_puppet }} -f /Rakefile metadata_lint
docker run --rm -v $(pwd):/repo ci/voxbox:${{ matrix.rubygem_puppet }} -f /Rakefile strings:validate:reference
docker run --rm -v $(pwd):/repo ci/voxbox:${{ matrix.rubygem_puppet }} -f /Rakefile rubocop
docker run --rm -v $(pwd):/repo ci/voxbox:${{ matrix.rubygem_puppet }} -f /Rakefile syntax
docker run --rm -v $(pwd):/repo ci/voxbox:${{ matrix.rubygem_puppet }} -f /Rakefile spec
docker run --rm -v $(pwd):/repo ci/voxbox:${{ matrix.rubygem_puppet }} -f /Rakefile r10k:syntax
docker run --rm -v $(pwd):/repo ci/voxbox:${{ matrix.rubygem_puppet }} -f /Rakefile r10k:dependencies

tests:
needs:
Expand Down