Fixes ordering for ipsets so that ipsets are defined before they are used #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before they are used. Confirm autorequires for rich_rules and ipsets. Make sure the ipset autorequires is actually for :firewalld_ipset. Code error. Code error. Ensure the custom service name is correctly formed for rich rule autorequire. Ensure ipsets are created before they are used. Updated ordering for other resource types as well. Updated ordering for port resources as well. Cleanup code style for pull request.
jcpunk
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This pull request addresses an ordering issue for ipsets.
Previous behaviour potentially left the running firewall in a state that allowed no traffic to or
from the host. This could be triggered by adding a new ipset.
An earlier commit added autorequires for ipsets that referenced an incorrect type of :ipset and not the correct :firewalld_ipset.
There was an additional ordering issue in the application of the hiera defined configuration in the firewalld class,
where ipsets were being applied after resources that could potentially make use of them.
I have re-ordered the resources in code to ensure that that dependencies can be met.
This Pull Request (PR) fixes the following issues