add some fact checks to not add php5.6 repo to new alma/redhat system… #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s - because remi url for php 5.6 is not valid for alma and redhat 8/9
|
Thank you for your contribution. Please add tests and fix the style warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
current redhat.pp will add wrong .repo files to new redhat and almalinux (8 and 9) systems. You run into a 404 by default with this redhat.pp
This Pull Request (PR) fixes the following issues
Now we check the releaseversion, and if you run a AlmaLinux or Redhat System in version 8 or 9, you will not receive the remi-php56.repo file, because there is no existing repo url.
Cheers
Christian