perf: vectorize standard basis construction - #1890
Merged
Merged
Conversation
Signed-off-by: 09Catho <ashketchume45@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Owner
|
Thanks, and welcome to toqito! Confirmed the np.eye version matches the previous output exactly in both flatten modes across dimensions, and the parametrized exact-equality tests are a nice improvement over the originals. Big speedup too. Merging. |
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numpy.eyePerformance
Measured locally with Python 3.13 and NumPy through the project
uvenvironment:The benchmark also asserted
np.array_equalbetween the previous and new outputs.Validation
uv run pytest toqito/matrices/tests -q(143 passed)uv run ruff check toqito/matrices/standard_basis.py toqito/matrices/tests/test_standard_basis.pyuv run ruff format --check toqito/matrices/standard_basis.py toqito/matrices/tests/test_standard_basis.pygit diff --checkCloses #1887