test: parametrize Horodecki state dimensions#1897
Open
Jethin10 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Horodecki state tests by consolidating multiple dimension-specific checks into a single parametrized test, using full-precision expected matrices and tightening numeric tolerances to better detect incorrect outputs.
Changes:
- Replaces separate 3×3 (default + explicit) and 2×4 tests with one
@pytest.mark.parametrizetest over supported dimensions. - Introduces full-precision expected density matrices as module-level constants.
- Tightens
assert_allclosetolerance (including for the 2×4 case) toatol=1e-12withrtol=0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+44
to
+47
| def test_horodecki_state_dimensions(dim, expected_res): | ||
| """The Horodecki state for each supported dimension.""" | ||
| res = horodecki(0.5, dim) | ||
| np.testing.assert_allclose(res, expected_res, rtol=0, atol=1e-12) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
uv run pytest toqito/states/tests/test_horodecki.py -q(6 passed)uv run ruff check toqito/states/tests/test_horodecki.pyuv run ruff format --check toqito/states/tests/test_horodecki.pyuv run ty check toqito/states/tests/test_horodecki.pyty check toqitocurrently reports existing diagnostics outside this changed test fileAddresses #1896.