Skip to content

How did it even work and pass the tests? #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2019
Merged

How did it even work and pass the tests? #4

merged 1 commit into from
Jan 31, 2019

Conversation

FluorescentHallucinogen
Copy link
Contributor

If argument passes the constraint validation, errors is an empty array.

If argument passes the constraint validation, `errors` is an empty array.
@vsimko vsimko merged commit fb1ecee into vsimko:master Jan 31, 2019
@FluorescentHallucinogen
Copy link
Contributor Author

@vsimko Could you please publish a new v3.2.1 to NPM?

@FluorescentHallucinogen
Copy link
Contributor Author

@vsimko Any plans to refine the tests to prevent something like that? 😉

@vsimko
Copy link
Owner

vsimko commented Jan 31, 2019

v3.2.1 published to npm
I'll come back to this later when I'll be again working on the graphql backend in my app.

Anyway, thanks for contributing.
Feel free to add more tests. 😉

@FluorescentHallucinogen
Copy link
Contributor Author

@vsimko

Feel free to add more tests. 😉

Ok, I'll add more tests. Looks like it's not too hard. 😉

Could you please better implement #6? 🙏

I really need this feature for my project, but, unfortunately, I don’t have much experience in writing directives (at the moment, I’m only actively exploring everything related to GraphQL directives). You would help me a lot.

I've tried https://github.com/confuser/graphql-constraint-directive, but it has serious problems that make it almost unusable.

@ecker00
Copy link

ecker00 commented Feb 1, 2019

I'm in the same boat as @FluorescentHallucinogen , seems that this library works better than graphql-constraint-directive, but would be awesome to have it working on both ARGUMENT_DEFINITION | INPUT_FIELD_DEFINITION. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants