Skip to content

Add action filter chips to history screen - #11

Merged
vssinghh merged 1 commit into
vssinghh:mainfrom
komallsingh:feature/history-filter-chips
Jul 3, 2026
Merged

Add action filter chips to history screen#11
vssinghh merged 1 commit into
vssinghh:mainfrom
komallsingh:feature/history-filter-chips

Conversation

@komallsingh

Copy link
Copy Markdown
Contributor

Summary

Adds action-based filtering to the History screen using Material 3 FilterChips, allowing users to quickly filter notification logs by action type.

Closes #

Changes

HistoryViewModel

  • Added selectedFilter state using RuleAction?
  • Implemented filter toggle behavior:
    • Selecting a chip applies the filter
    • Selecting the active chip again clears the filter
  • Updated historyLogs flow to combine:
    • Search query filtering
    • Action-based filtering
  • Removed string-based tab filtering logic in favor of strongly typed RuleAction filtering

HistoryScreen

  • Added a row of Material 3 FilterChips below the search bar
  • Added filters for:
    • Blocked (RuleAction.BLOCK)
    • Muted (RuleAction.MUTE)
    • Delivered (RuleAction.ALLOW)
  • Connected chip selection state to the ViewModel
  • Preserved existing search functionality while supporting combined search + action filtering

Behavior

Action Result
Tap Blocked Shows only blocked notifications
Tap Muted Shows only muted notifications
Tap Delivered Shows only delivered notifications
Tap active chip again Clears filter and shows all notifications
Search + Filter Both filters are applied together

Testing

Tested on Android emulator.

Verified

  • Filter chips are displayed below the search bar
  • Blocked filter shows only blocked notifications
  • Muted filter shows only muted notifications
  • Delivered filter shows only delivered notifications
  • Tapping an active filter clears the filter
  • Search functionality continues to work correctly
  • Search and action filters work together
  • No crashes or UI regressions observed

Closes #4

@vssinghh
vssinghh self-requested a review July 3, 2026 21:43
@vssinghh
vssinghh merged commit 10b4184 into vssinghh:main Jul 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add filter chips to History screen (Blocked / Muted / Allowed)

2 participants