Skip to content

fix(runtime-core): stop tracking deps in setRef during unmount #13210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

makedopamine
Copy link
Contributor

fix #13209

Copy link

github-actions bot commented Apr 16, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+12 B) 38.1 kB (+4 B) 34.4 kB (+13 B)
vue.global.prod.js 158 kB (+12 B) 58.3 kB (+4 B) 51.9 kB (+22 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB (+12 B) 18.1 kB (+6 B) 16.6 kB (+5 B)
createApp 54.4 kB (+12 B) 21.2 kB (+7 B) 19.4 kB (+11 B)
createSSRApp 58.6 kB (+12 B) 22.9 kB (+10 B) 20.9 kB (+6 B)
defineCustomElement 59.2 kB (+12 B) 22.7 kB (+8 B) 20.7 kB (-1 B)
overall 68.5 kB (+12 B) 26.4 kB (+9 B) 24 kB (+68 B)

Copy link

pkg-pr-new bot commented Apr 16, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13210

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13210

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13210

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13210

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13210

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13210

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13210

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13210

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13210

vue

npm i https://pkg.pr.new/vue@13210

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13210

commit: 4549e03

@edison1105
Copy link
Member

It doesn't seem to have fixed it. Playground with this PR

@makedopamine
Copy link
Contributor Author

Updated. Could you please confirm this again?

@edison1105 edison1105 added ready to merge The PR is ready to be merged. ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Apr 17, 2025
@edison1105
Copy link
Member

@makedopamine Nice. It's fixed.

@ferferga
Copy link
Contributor

Can we have tests for this? I see this easily being reintroduced if this code ever gets refactored.

@edison1105
Copy link
Member

Can we have tests for this? I see this easily being reintroduced if this code ever gets refactored.

Agreed! Could you contribute a test case if you'd like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detached elements casued by getting computed value in ref function
3 participants