fix: make mount options slots compatible with noUncheckedIndexedAccess true #2713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s true It's not necessary to define all slots, pratially defined slots are used all over the place throughout the tests here and routinely by users. However, the type for slots in mount options was not partiall and that caused type errors for people using `noUncheckedIndexedAccess: true` even though it work fine in runtime. Adding `?` doesn't change anything for users with `noUncheckedIndexedAccess: false`, it has passed type checking before and will continue to pass. Type checking will now also pass for users with partially defined slots using `noUncheckedIndexedAccess: true`.
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cexbrayat
requested changes
Sep 19, 2025
There was a problem hiding this comment.
Could you add a test in https://github.com/vuejs/test-utils/tree/main/test-dts to repro what you're trying to do? You can probably enable the option in https://github.com/vuejs/test-utils/blob/main/test-dts/tsconfig.tsd.json
|
I added the missing test |
cexbrayat
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary to define all slots, pratially defined slots are used all over the place throughout the tests here and routinely by users. However, the type for slots in mount options was not partiall and that caused type errors for people using
noUncheckedIndexedAccess: trueeven though it work fine in runtime. Adding?doesn't change anything for users withnoUncheckedIndexedAccess: false, it has passed type checking before and will continue to pass. Type checking will now also pass for users with partially defined slots usingnoUncheckedIndexedAccess: true.