Skip to content

Throw error when component is undefined or null (#2038) #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Throw error when component is undefined or null (#2038) #2041

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68636d9
throw error when component is undefined or null
AlbertLucianto Feb 2, 2018
07c2e73
Update create-route-map.js
posva Feb 2, 2018
60a3d98
fix false error when it is not just a component
AlbertLucianto Feb 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/create-route-map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ function addRouteRecord (
`route config "component" for path: ${String(path || name)} cannot be a ` +
`string id. Use an actual component instead.`
)
assert(
route.component,
`route config "component" for path: ${String(path || name)} cannot be ${String(route.component)}.`
)
}

const pathToRegexpOptions: PathToRegexpOptions = route.pathToRegexpOptions || {}
Expand Down
7 changes: 7 additions & 0 deletions test/unit/specs/create-map.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,13 @@ describe('Creating Route Map', function () {
}).toThrowError(/"path" is required/)
})

it('in development, throws if component is null or undefined', function () {
process.env.NODE_ENV = 'development'
expect(() => {
maps = createRouteMap([{ path: '/' }])
}).toThrowError(/route config "component" for path/)
})

Copy link

@vinibrsl vinibrsl Feb 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would create an spec similar to this one, but to test that this is not affecting production env, with not.toHaveBeenCalled 👍

it('in production, it has not logged this warning', function () {
maps = createRouteMap(routes)
expect(console.warn).not.toHaveBeenCalled()
Expand Down