docs: add missing import to example #1637
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Aug 4, 2025
docs/guide/storage.md
Outdated
| @@ -79,7 +79,7 @@ VueFire also exposes a smaller composable that only retrieves the url of a file. | |||
| <script setup lang="ts"> | |||
| import { useFileDialog } from '@vueuse/core' | |||
| import { ref as storageRef } from 'firebase/storage' | |||
| import { useFirebaseStorage, useStorageFile } from 'vuefire' | |||
| import { useFirebaseStorage, useStorageFile, useStorageFileUrl } from 'vuefire' | |||
There was a problem hiding this comment.
Suggested change
| import { useFirebaseStorage, useStorageFile, useStorageFileUrl } from 'vuefire' | |
| import { useFirebaseStorage, useStorageFileUrl } from 'vuefire' |
| @@ -79,7 +79,7 @@ VueFire also exposes a smaller composable that only retrieves the url of a file. | |||
| <script setup lang="ts"> | |||
There was a problem hiding this comment.
Can you add a line above to highlight the added lines:
vue{4,?}
posva
requested changes
Aug 6, 2025
docs/guide/storage.md
Outdated
| @@ -75,11 +75,10 @@ Once the picture is uploaded, you can use the `url` reactive variable. For examp | |||
|
|
|||
| VueFire also exposes a smaller composable that only retrieves the url of a file. This is useful if you don't need to upload a file but only display it: | |||
|
|
|||
| ```vue | |||
| ```vue{4,?} | |||
There was a problem hiding this comment.
Suggested change
| ```vue{4,?} | |
| ```vue{4,11} |
There was a problem hiding this comment.
By ? I meant the actual line after editing, sorry it wasn't clear 😆
docs/guide/storage.md
Outdated
| <script setup lang="ts"> | ||
| import { useFileDialog } from '@vueuse/core' | ||
| import { ref as storageRef } from 'firebase/storage' | ||
| import { useFirebaseStorage, useStorageFile } from 'vuefire' |
There was a problem hiding this comment.
I meant the import here should also be adapted
|
Ah, thanks for clarifying. I took some time to clarify the copy on the page too. Hope that's okay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.