feat(VTreeview): expose depth, path, index in slots#19833
Merged
Conversation
e20cfec to
2766105
Compare
4c970f9 to
6a3285f
Compare
0756d45 to
1dad494
Compare
Contributor
|
Personally I would not use it over drag&drop (except for mobile views), but I could see an appeal of
|
johnleider
requested changes
May 16, 2025
Member
johnleider
left a comment
There was a problem hiding this comment.
Everything looks good, but I feel the example is a little too complex. I started to provide some feedback but really it just needs to be approached in a much smaller scope.
packages/docs/src/examples/v-treeview/slot-append-and-prepend-item.vue
Outdated
Show resolved
Hide resolved
packages/docs/src/examples/v-treeview/slot-append-and-prepend-item.vue
Outdated
Show resolved
Hide resolved
packages/docs/src/examples/v-treeview/slot-append-and-prepend-item.vue
Outdated
Show resolved
Hide resolved
Contributor
|
Example revisions:
Notes:
|
3f5b2e3 to
07e0bd8
Compare
Contributor
|
johnleider
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
screencast-localhost_8090-2024.05.17-02_34_41.webm
Markup:
Add index, depth, path to VTreeView