feat(VBadge): add size width and height props to VBadge (#28037)#21509
Merged
feat(VBadge): add size width and height props to VBadge (#28037)#21509
Conversation
7bc411e to
12b6f9c
Compare
J-Sek
previously requested changes
Jun 7, 2025
Contributor
|
Is it OK that these are not reactive? Ofc, we could patch it later after learning about some real-life use cases proving it matters. Playground<template>
<v-container max-width="400">
<v-slider
v-model="height"
label="height"
max="100"
min="0"
step="1"
/>
<v-slider
v-model="width"
label="width"
max="100"
min="0"
step="1"
/>
</v-container>
<v-container max-width="400">
<v-badge :key="height + width" :height="height" :width="width" content="123" />
</v-container>
</template>
<script setup lang="ts">
import { ref } from 'vue'
const height = ref<number | null>(null)
const width = ref<number | null>(null)
</script> |
Contributor
Author
Do you mean to say that the |
Updated to simplify the solution thanks J-Sek!
Contributor
The changes did not seem to be reflected unless I had Your last commit fixed it by passing |
J-Sek
approved these changes
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
widthandheightusing ourDimensionPropsMarkup: