Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow axios instance to be provided to plugin #19

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Feb 11, 2019

Proposed changes:

I noticed there are no tests for this plugin functionality, it however all works as expected. Changes were kept minimal (lock file was regenerated for the dependency changes, so that is the only significant change really) to allow them to be non breaking and a patch level fix.

@bmartel bmartel changed the title p… allow axios instance to be provided to plugin Feb 11, 2019
…s instance to be passed in to plugin fixes vuex-orm#18, vuex-orm#7 and expose axios instance to interceptors to allow for custom response handling with tokens fixes vuex-orm#7
@kiaking
Copy link
Member

kiaking commented Feb 12, 2019

@bmartel Hi! Thank you so much for the PR! Looks good to me. I'll merge this and release a new version soon 👍

@pultho
Copy link

pultho commented Mar 14, 2019

Any update on this one? Pull-requests haven't been merged yet 😔

@KaniRobinson KaniRobinson merged commit 70cc314 into vuex-orm:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants