Skip to content

Add since and pagination to get_vendor_product_vulnerabilities() #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

flesueur
Copy link

@flesueur flesueur commented May 9, 2025

Hi,

This PR adds :

  • since parameter, exposed by the API, to the python binding;
  • pagination, to retrieve all results matching the query.

I'm not very confident in the while condition to detect that we got all results, maybe another test would fit better ?

Cheers,
François

@Rafiot
Copy link
Collaborator

Rafiot commented May 9, 2025

Thank you for the PR!

I'll need to play a bit with it, but I think it wound be better to stop when the length of the response is to the limit, I fear the request as it is could fail is weird ways.

@Rafiot Rafiot self-assigned this May 9, 2025
@flesueur
Copy link
Author

flesueur commented May 9, 2025

Something like that ? Length of the response could be calculated in a reduce one-liner, but I'm not sure if it would help readability.

@flesueur
Copy link
Author

Hi,

I saw some tests failed (seems redis) and some others infinitely looped. It does not seem related to my code, when I launch tests on my side on the changed function it looks ok.

Just to be sure, are u expecting something from me ?

Cheers
François

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants