Fixed compilation errors and updated dependencies #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng lookup failure; Fixed warnings
|
No, this is largely unmaintained and actually pretty out of date. The latest version was in the forked(networkprotocol/netcode.io) library but was since removed since I didn't have time to maintain it. You're totally welcome to fork it if you want since I probably won't have time to properly review PRs. |
|
yeah I noticed it was a bit out of date haha I've fixed a few more bugs and merged it back with the original project over here I can't see myself picking up the maintenance effort, just leaving this here for future reference :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey I don't know if you're still actively maintaining this project but I had to make a few changes to get it building on my system and I figured I might as well submit a PR
The version from cargo.io fails to locate clang on my system because of how the version of clang-sys used found clang. In essence, on OSes without a standard 'exe' extension it will match directories named 'clang' as well as binaries - the version I've updated it to has checks to avoid this.
Also there's two hard compilation errors in client.rs which I assume were just uncaught copy-paste errors or something. Simple fix but again, the version on cargo.io doesn't compile without it