Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T5992: show dhcpv6 leases with (mostly) the same fields as dhcp leases #4289

Closed
wants to merge 2 commits into from

Conversation

nvandamme
Copy link
Contributor

@nvandamme nvandamme commented Jan 8, 2025

Change summary

Changed leases table headers for dhcpv6 leases to reflect mostly the same fields and order of dhcpv4 leases with respective op commands.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

vyos@vyos:~$ show dhcpv6 server leases
IPv6 address MAC address State Last communication Lease expiration Remaining Pool Hostname Type DUID
xxxx:xxxx:xxxx:xxxx::xxxx xx:xx:xx:xx:xx:xx active 2025/01/08 14:17:04 2025/01/08 16:17:04 1:46:14 LAN dummy IA_NA 00:03:00:01:xx:xx:xx:xx:xx:xx
vyos@vyos:~$ show dhcp server leases
IP Address MAC address State Lease start Lease expiration Remaining Pool Hostname Origin
xxx.xxx.xxx.xxx xx:xx:xx:xx:xx:xx active 2025/01/08 09:09:00 2025/01/09 09:09:00 18:07:38 LAN dummy local

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jan 8, 2025

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Jan 8, 2025

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@dmbaturin
Copy link
Member

@nvandamme Please resolve the conflicts, the logic looks good to me.

@nvandamme
Copy link
Contributor Author

@dmbaturin
The logic behind pulling keas mappings changed, i need to rewrite with the curent code.

@nvandamme nvandamme closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants