syslog: T6989: convert old configuration format to "advanced" #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-po
requested review from
dmbaturin,
sarthurdev,
jestabro,
sever-sever,
fett0,
nicolas-fort and
zdc
as code owners
|
👍 |
|
✅ No issues found in unused-imports check.. Please refer the workflow run |
1 task
dmbaturin
requested changes
Jan 20, 2025
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
dmbaturin
approved these changes
Jan 24, 2025
|
Note that the smoketest |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
11 tasks
Thank you - issue fixed in commit 9212b40 |
Should be added as runtime option similar to "terminal monitor" known from other vendors.
Move "global preserve-fqdn" one CLI level up, as it relates to all logging targets (console, global and remote).
The previously "global" options actually were only relevant for the local logging to /var/log/messages.
This is a feature that worked decades ago when logs were small and reviewed by a human, it fails badly on high volume logs processed by tools. https://www.rsyslog.com/doc/configuration/action/rsconf1_repeatedmsgreduction.html
Rsyslog supports individual VRFs per omfwd remote entry - so we should support this, too.
Some systemd services are re-used over multiple configuration files. Keep a single source of the real systemd names and only reference them by dictionary keys.
jestabro
approved these changes
Feb 4, 2025
|
CI integration 👍 passed! Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
We are still using the legacy config format for rsyslog in https://github.com/vyos/vyos-1x/blob/bb4611544ff73a979f927a7a1c8ea3dd1c56fb48/data/templates/rsyslog/rsyslog.conf.j2
It has been superseded by a new format:
https://www.rsyslog.com/doc/configuration/converting_to_new_format.html
There are some associated issues. For example, we use
$markMessagePeriodforset system syslog global marker interval, which sends mark messages unconditionally. New rsyslog versions support sending mark messages only if there are no real messages, the old directive is now listed as obsolete (https://www.rsyslog.com/doc/configuration/input_directives/rsconf1_markmessageperiod.html) and its replacement seems to be only available in the advanced format.fileCLI option to log to dedicated files.userCLI option to always log to user terminal - should be an op-mode command insteadhost <ipv4|ipv6|fqdn>->remote <ipv4|ipv6|fqdn>remote source-address <ipv4|ipv6|fqdn>remote vrf <name>global preserve-fqdn->preserve-fqdn- move up one CLI levelglobal marker interval->marker interval- move up one CLI levelglobal->localas every facility configured under global is actually logged locally to/var/log/messagesTypes of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Checklist: