vyconf: T6718: drop hybrid set/delete functions #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'hybrid' mode of vyconfd validation and Cstore commit is no longer needed, in preparation for full vyconfd support. Revert "vyconf: T6718: use vy_set/delete in configsession and util" This reverts commit 6999f85.
jestabro
requested review from
dmbaturin,
sarthurdev,
sever-sever,
c-po,
fett0,
nicolas-fort and
zdc
as code owners
|
👍 |
10 tasks
|
CI integration ❌ failed! Details
|
c-po
approved these changes
Feb 2, 2025
dmbaturin
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
The period of a 'hybrid' mode using vyconfd validation with Cstore data structures was useful for developing vyconfd, utilities, and algorithms, but is no longer needed. Remaining vyconfd development will continue in parallel to the legacy system until a full replacement.
Types of changes
- drop interim hybrid configuration
Related Task(s)
Related PR(s)
How to test / Smoketest result
Checklist: