installer: T7102: download upgrade images to a random path in the root filesystem #4330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
As of now, the image upgrade script always downloads the new image to
/tmp/vyos_installation.iso
. There are two problems with that approach:/tmp
is a RAM-backedtmpfs
, which means upgrade can fail if the system doesn't have enough free RAM to store a ~600MB image. Even if it does have that memory, a completely avoidable 600M RAM usage spike still isn't a good idea.add system image
at once, using a fixed location will lead to funny errors.Storing the temporary image in the persistent root filesystem and using a random name for it solves both problems.
This PR is somewhat ugly — that's the price of making it minimal and easy to backport. The script can certainly benefit from a deep refactoring.
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Checklist: