Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T7121: Set up communication vyconfd to vyos-commitd #4398

Merged
merged 10 commits into from
Mar 18, 2025
Merged

T7121: Set up communication vyconfd to vyos-commitd #4398

merged 10 commits into from
Mar 18, 2025

Conversation

jestabro
Copy link
Contributor

Change summary

Draft pending merge of:
vyos/vyos-build#931
vyos/libvyosconfig#26
and update of libvyosconfig commit hash in Makefile.

Define vyos-commitd to provide execution of config-mode scripts in response to vyconfd commit requests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyos-build#931
vyos/libvyosconfig#26

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

jestabro added 9 commits March 16, 2025 23:55
@jestabro
T6946: add wrapper for show_commit_data and test function
dbe09d4
@jestabro
T7121: add configtree read/write to internal representation
defc2b6
@jestabro
T7121: use dunder equal instead of string rep comparison, where possible
4dc02b4
@jestabro
T7121: add protobuf and tomli dependencies
467811b 
Add protobuf dependencies for communication vyconfd <-> vyos-commitd,
and tomli runtime dependency for vyos-commitd load of vyconfd.conf.
@jestabro
T7121: add Config init from internal cache
33394e4 
The internal cache is used as a faster replacement to parsing the active
and proposed configs on initialization of a commit session.
@jestabro
T7121: generate Python protobuf files at build
3078c7c
@jestabro
T7121: add defaults entry for vyconfd.conf
b3427a6 
The vyconfd configuration file contains socket name, canonical
directories, and file names shared with vyos-commitd.
@jestabro
T7121: add vyos-commitd service as emergent replacement for vyos-configd
21d960b 
vyos-commitd exchanges messages with vyconfd, to replace the shim
redirection of legacy commands to vyos-configd.
@jestabro
T7121: add test_commit wrapper and test script
b6df26f
@jestabro jestabro self-assigned this Mar 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 17, 2025 •
edited
Loading

👍
No issues in PR Title / Commit Title

@jestabro jestabro mentioned this pull request Mar 17, 2025
Closed
12 tasks
@jestabro jestabro marked this pull request as ready for review March 18, 2025 15:38
@jestabro jestabro requested a review from a team as a code owner March 18, 2025 15:38
@dmbaturin dmbaturin merged commit 78a3ba7 into vyos:current Mar 18, 2025
15 of 16 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Mar 18, 2025
@github-actions GitHub Actions
Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@c-po c-po c-po approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees

@jestabro jestabro

Labels
current mirror-completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jestabro @dmbaturin @c-po @vyosbot