Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T7226: Added FRR patch with option that disables LDP hello #932

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

AndriiFullroot
Copy link

Added patch for FRR that adds option to disable "addition LDP hello message during TCP session establishing".

Added option "disable-establish-hello" that disables sending additional LDP hello multicast messages during TCP session establishment. This option enables per interface: "(config-ldp-af-if)"

Usage example:

VyOS# configure
VyOS(config)# mpls ldp
VyOS(config-ldp)# address-family ipv4
VyOS(config-ldp-af)# interface eth0
VyOS(config-ldp-af-if)# disable-establish-hello
VyOS(config-ldp-af-if)# end
VyOS# 

NOTE: Additional VyOS binding required.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7226

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Mar 17, 2025

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Mar 17, 2025
@sever-sever
Copy link
Member

sever-sever commented Mar 17, 2025

  1. The path for patches is wrong.
  2. This is a wrong format commit message
T7226 Added FRR patch with option that disables LDP hello 

Expected T7226: Added FRR patch with option that disables LDP hello

@aapostoliuk
Copy link
Contributor

I have tested it in my lab. It works. But when I configure it, I do not see this command in the show run in FRR.

@sever-sever sever-sever changed the title T7226 Added FRR patch with option that disables LDP hello T7226: Added FRR patch with option that disables LDP hello Mar 17, 2025
@sever-sever sever-sever merged commit 7509516 into vyos:current Mar 18, 2025
3 checks passed
@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release mirror-completed
Development

Successfully merging this pull request may close these issues.

5 participants