Skip to content

Fix infinite recursion causing segfault on unclosed parenthesis #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
newwin01 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix infinite recursion causing segfault on unclosed parenthesis #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73210a7
fix infinite loop bug
newwin01 Dec 4, 2025
3607527
fix infinite loop on other bracket types
newwin01 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions tl-parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,10 @@ struct tree *parse_term (void) {
}
if (LEX_CHAR ('(')) {
EXPECT ("(");
// EOF or end of valid input check to prevent infinite recursion
if (!curch || parse.pos >= parse.len) {
PARSE_FAIL;
}
PARSE_TRY_PES (parse_expr);
EXPECT (")");
PARSE_OK;
Expand All @@ -559,6 +563,10 @@ struct tree *parse_term (void) {
tree_add_child (T, S);
if (LEX_CHAR ('<')) {
EXPECT ("<");
// EOF check to prevent infinite recursion
if (!curch || parse.pos >= parse.len) {
PARSE_FAIL;
}
while (1) {
PARSE_TRY_PES (parse_expr);
if (LEX_CHAR ('>')) { break; }
Expand Down Expand Up @@ -664,6 +672,10 @@ struct tree *parse_partial_type_app_decl (void) {
PARSE_TRY_PES (parse_boxed_type_ident);
if (LEX_CHAR ('<')) {
EXPECT ("<");
// EOF check to prevent infinite recursion
if (!curch || parse.pos >= parse.len) {
PARSE_FAIL;
}
while (1) {
PARSE_TRY_PES (parse_expr);
if (LEX_CHAR ('>')) { break; }
Expand Down Expand Up @@ -766,6 +778,10 @@ struct tree *parse_args2 (void) {
load_parse (save2);
}
EXPECT ("[");
// EOF check to prevent infinite recursion
if (!curch || parse.pos >= parse.len) {
PARSE_FAIL;
}
while (1) {
if (LEX_CHAR (']')) { break; }
PARSE_TRY_PES (parse_args);
Expand All @@ -777,6 +793,10 @@ struct tree *parse_args2 (void) {
struct tree *parse_args1 (void) {
PARSE_INIT (type_args1);
EXPECT ("(");
// EOF check to prevent infinite recursion
if (!curch || parse.pos >= parse.len) {
PARSE_FAIL;
}
while (1) {
PARSE_TRY_PES (parse_var_ident_opt);
if (LEX_CHAR(':')) { break; }
Expand Down Expand Up @@ -838,6 +858,10 @@ struct tree *parse_result_type (void) {
PARSE_TRY_PES (parse_boxed_type_ident);
if (LEX_CHAR ('<')) {
EXPECT ("<");
// EOF check to prevent infinite recursion
if (!curch || parse.pos >= parse.len) {
PARSE_FAIL;
}
while (1) {
PARSE_TRY_PES (parse_expr);
if (LEX_CHAR ('>')) { break; }
Expand Down