use ContentControl with template for TemplateColumn - #214
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with data binding in template columns by replacing direct template content loading with ContentControl-based rendering. The change ensures that x:Bind and Binding.Converters work correctly in template columns by leveraging the proper data binding infrastructure.
- Updated
GenerateElementto useContentControlwithContentTemplateinstead ofDataTemplate.LoadContent() - Updated
GenerateEditingElementto use the sameContentControlapproach for editing templates - Maintains existing fallback behavior when editing templates are not defined
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188 and might also address #211.
This PR updates the way cell content is loaded in a template column. Previously, the content was manually set after loading the template using
DataTemplate.LoadContent(), which caused issues withx:BindandBinding.Converters. The new approach uses aContentControlwith the cell template, which is then used as the cell content.