Added WinRT attribute to Columns - #215
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds WinRT binding support for TableView column classes by applying the [WinRT.GeneratedBindableCustomProperty] attribute to all column types, enabling proper custom property generation for WinRT bindings on Windows platforms.
- Adds conditional
[WinRT.GeneratedBindableCustomProperty]attribute to all TableView column classes (gated behindWINDOWScompilation directive) - Changes affected column classes from non-partial to
partialto enable extensibility and code generation compatibility - Updates both concrete column implementations and abstract base classes for consistent WinRT support
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| TableViewBoundColumn.cs | Added WinRT attribute to abstract base class for bound columns |
| TableViewColumn.cs | Added WinRT attribute and made abstract base class partial |
| TableViewCheckBoxColumn.cs | Added WinRT attribute and made class partial |
| TableViewComboBoxColumn.cs | Added WinRT attribute and made class partial |
| TableViewDateColumn.cs | Added WinRT attribute (class already partial) |
| TableViewNumberColumn.cs | Added WinRT attribute and made class partial |
| TableViewTemplateColumn.cs | Added WinRT attribute and made class partial |
| TableViewTextColumn.cs | Added WinRT attribute and made class partial |
| TableViewTimeColumn.cs | Added WinRT attribute (class already partial) |
| TableViewToggleSwitchColumn.cs | Added WinRT attribute and made class partial |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
w-ahmad
reviewed
Sep 11, 2025
w-ahmad
approved these changes
Sep 11, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the
[WinRT.GeneratedBindableCustomProperty]attribute to several TableView column classes to improve WinRT binding support on Windows platforms. Additionally, it changes the affected classes from non-partial topartialwhere appropriate, enabling further extensibility and compatibility with code generation tools.I did this to ensure that if columns are auto generated, WinRT bindings work correctly.
WinRT binding support enhancements:
[WinRT.GeneratedBindableCustomProperty]attribute to all TableView column classes, gated behind theWINDOWSconditional compilation directive. This ensures custom property generation for WinRT bindings only on Windows. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Class definition changes for extensibility:
TableViewCheckBoxColumn,TableViewComboBoxColumn,TableViewDateColumn,TableViewNumberColumn,TableViewTemplateColumn,TableViewTextColumn,TableViewTimeColumn,TableViewToggleSwitchColumn) to bepartialclasses, allowing for future extensions and compatibility with code generation. [1] [2] [3] [4] [5] [6] [7] [8]Base class updates:
TableViewBoundColumnandTableViewColumnto include the new attribute and, forTableViewColumn, to bepartialas well. [1] [2]