Skip to content

Let the host application supply TableView's strings #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SolidRockProgrammer wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Let the host application supply TableView's strings #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
977c763
Localize the automation peers' control types and row names
claude Oct 1, 2026
ad90bff
Test the indexed row names through the row, row-header and cell peers
SolidRockProgrammer Oct 3, 2026
f312527
Let the host application supply TableView's strings
claude Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AutomationPeers/TableViewAutomationPeer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ protected override AutomationControlType GetAutomationControlTypeCore()
/// <inheritdoc/>
protected override string GetLocalizedControlTypeCore()
{
return "table view";
return TableViewLocalizedStrings.TableViewControlType;
}

/// <inheritdoc/>
Expand Down
4 changes: 2 additions & 2 deletions src/AutomationPeers/TableViewCellAutomationPeer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ protected override AutomationControlType GetAutomationControlTypeCore()
/// <inheritdoc/>
protected override string GetLocalizedControlTypeCore()
{
return "cell";
return TableViewLocalizedStrings.CellControlType;
}

/// <inheritdoc/>
Expand Down Expand Up @@ -71,7 +71,7 @@ protected override string GetNameCore()
: string.Empty;

var rowIndex = _owner.Row?.Index ?? -1;
var rowDisplay = rowIndex >= 0 ? $"Row {rowIndex + 1}" : string.Empty;
var rowDisplay = rowIndex >= 0 ? TableViewLocalizedStrings.FormatRowNumber(rowIndex + 1) : string.Empty;

var cellValue = _owner.Column is TableViewTemplateColumn
? string.Empty
Expand Down
2 changes: 1 addition & 1 deletion src/AutomationPeers/TableViewColumnHeaderAutomationPeer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ protected override AutomationControlType GetAutomationControlTypeCore()
/// <inheritdoc/>
protected override string GetLocalizedControlTypeCore()
{
return "column header";
return TableViewLocalizedStrings.ColumnHeaderControlType;
}

/// <inheritdoc/>
Expand Down
2 changes: 1 addition & 1 deletion src/AutomationPeers/TableViewRowAutomationPeer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ protected override string GetNameCore()
}

var index = _owner.Index;
return index >= 0 ? $"Row {index + 1}" : "Row";
return index >= 0 ? TableViewLocalizedStrings.FormatRowNumber(index + 1) : TableViewLocalizedStrings.Row;
}

/// <inheritdoc/>
Expand Down
4 changes: 2 additions & 2 deletions src/AutomationPeers/TableViewRowHeaderAutomationPeer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ protected override AutomationControlType GetAutomationControlTypeCore()
/// <inheritdoc/>
protected override string GetLocalizedControlTypeCore()
{
return "row header";
return TableViewLocalizedStrings.RowHeaderControlType;
}

/// <inheritdoc/>
Expand Down Expand Up @@ -77,6 +77,6 @@ protected override string GetNameCore()

// Fall back to the row index
var rowIndex = _owner.TableViewRow?.Index ?? -1;
return rowIndex >= 0 ? $"Row {rowIndex + 1}" : base.GetNameCore();
return rowIndex >= 0 ? TableViewLocalizedStrings.FormatRowNumber(rowIndex + 1) : base.GetNameCore();
}
}
24 changes: 24 additions & 0 deletions src/Strings/de-DE/WinUI.TableView.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,28 @@
<data name="SortGroupsByValue" xml:space="preserve">
<value>Gruppen nach Wert sortieren</value>
</data>
<data name="TableViewControlType" xml:space="preserve">
<value>Tabellenansicht</value>
<comment>UI Automation localized control type of the TableView.</comment>
</data>
<data name="ColumnHeaderControlType" xml:space="preserve">
<value>Spaltenkopf</value>
<comment>UI Automation localized control type of a column header.</comment>
</data>
<data name="RowHeaderControlType" xml:space="preserve">
<value>Zeilenkopf</value>
<comment>UI Automation localized control type of a row header.</comment>
</data>
<data name="CellControlType" xml:space="preserve">
<value>Zelle</value>
<comment>UI Automation localized control type of a cell.</comment>
</data>
<data name="RowNumber" xml:space="preserve">
<value>Zeile {0}</value>
<comment>UI Automation name of a row; {0} is the one-based row number.</comment>
</data>
<data name="Row" xml:space="preserve">
<value>Zeile</value>
<comment>UI Automation name of a row whose index is not known.</comment>
</data>
</root>
24 changes: 24 additions & 0 deletions src/Strings/en-US/WinUI.TableView.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,28 @@
<data name="SortGroupsByValue" xml:space="preserve">
<value>Sort Groups by Value</value>
</data>
<data name="TableViewControlType" xml:space="preserve">
<value>table view</value>
<comment>UI Automation localized control type of the TableView.</comment>
</data>
<data name="ColumnHeaderControlType" xml:space="preserve">
<value>column header</value>
<comment>UI Automation localized control type of a column header.</comment>
</data>
<data name="RowHeaderControlType" xml:space="preserve">
<value>row header</value>
<comment>UI Automation localized control type of a row header.</comment>
</data>
<data name="CellControlType" xml:space="preserve">
<value>cell</value>
<comment>UI Automation localized control type of a cell.</comment>
</data>
<data name="RowNumber" xml:space="preserve">
<value>Row {0}</value>
<comment>UI Automation name of a row; {0} is the one-based row number.</comment>
</data>
<data name="Row" xml:space="preserve">
<value>Row</value>
<comment>UI Automation name of a row whose index is not known.</comment>
</data>
</root>
24 changes: 24 additions & 0 deletions src/Strings/es-ES/WinUI.TableView.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,28 @@
<data name="SortGroupsByValue" xml:space="preserve">
<value>Ordenar grupos por valor</value>
</data>
<data name="TableViewControlType" xml:space="preserve">
<value>vista de tabla</value>
<comment>UI Automation localized control type of the TableView.</comment>
</data>
<data name="ColumnHeaderControlType" xml:space="preserve">
<value>encabezado de columna</value>
<comment>UI Automation localized control type of a column header.</comment>
</data>
<data name="RowHeaderControlType" xml:space="preserve">
<value>encabezado de fila</value>
<comment>UI Automation localized control type of a row header.</comment>
</data>
<data name="CellControlType" xml:space="preserve">
<value>celda</value>
<comment>UI Automation localized control type of a cell.</comment>
</data>
<data name="RowNumber" xml:space="preserve">
<value>Fila {0}</value>
<comment>UI Automation name of a row; {0} is the one-based row number.</comment>
</data>
<data name="Row" xml:space="preserve">
<value>Fila</value>
<comment>UI Automation name of a row whose index is not known.</comment>
</data>
</root>
24 changes: 24 additions & 0 deletions src/Strings/fa-IR/WinUI.TableView.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,28 @@
<data name="SortGroupsByValue" xml:space="preserve">
<value>مرتب‌ سازی گروه‌ ها بر اساس مقدار</value>
</data>
<data name="TableViewControlType" xml:space="preserve">
<value>نمای جدول</value>
<comment>UI Automation localized control type of the TableView.</comment>
</data>
<data name="ColumnHeaderControlType" xml:space="preserve">
<value>سرستون</value>
<comment>UI Automation localized control type of a column header.</comment>
</data>
<data name="RowHeaderControlType" xml:space="preserve">
<value>سرسطر</value>
<comment>UI Automation localized control type of a row header.</comment>
</data>
<data name="CellControlType" xml:space="preserve">
<value>خانه</value>
<comment>UI Automation localized control type of a cell.</comment>
</data>
<data name="RowNumber" xml:space="preserve">
<value>سطر {0}</value>
<comment>UI Automation name of a row; {0} is the one-based row number.</comment>
</data>
<data name="Row" xml:space="preserve">
<value>سطر</value>
<comment>UI Automation name of a row whose index is not known.</comment>
</data>
</root>
24 changes: 24 additions & 0 deletions src/Strings/ja-JP/WinUI.TableView.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,4 +214,28 @@
<data name="SortGroupsByValue" xml:space="preserve">
<value>グループを値で並べ替え</value>
</data>
<data name="TableViewControlType" xml:space="preserve">
<value>テーブル ビュー</value>
<comment>UI Automation localized control type of the TableView.</comment>
</data>
<data name="ColumnHeaderControlType" xml:space="preserve">
<value>列ヘッダー</value>
<comment>UI Automation localized control type of a column header.</comment>
</data>
<data name="RowHeaderControlType" xml:space="preserve">
<value>行ヘッダー</value>
<comment>UI Automation localized control type of a row header.</comment>
</data>
<data name="CellControlType" xml:space="preserve">
<value>セル</value>
<comment>UI Automation localized control type of a cell.</comment>
</data>
<data name="RowNumber" xml:space="preserve">
<value>行 {0}</value>
<comment>UI Automation name of a row; {0} is the one-based row number.</comment>
</data>
<data name="Row" xml:space="preserve">
<value>行</value>
<comment>UI Automation name of a row whose index is not known.</comment>
</data>
</root>
24 changes: 24 additions & 0 deletions src/Strings/pl-PL/WinUI.TableView.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,5 +204,29 @@
<data name="SortGroupsByValue" xml:space="preserve">
<value>Sortuj grupy według wartości</value>
</data>
<data name="TableViewControlType" xml:space="preserve">
<value>widok tabeli</value>
<comment>UI Automation localized control type of the TableView.</comment>
</data>
<data name="ColumnHeaderControlType" xml:space="preserve">
<value>nagłówek kolumny</value>
<comment>UI Automation localized control type of a column header.</comment>
</data>
<data name="RowHeaderControlType" xml:space="preserve">
<value>nagłówek wiersza</value>
<comment>UI Automation localized control type of a row header.</comment>
</data>
<data name="CellControlType" xml:space="preserve">
<value>komórka</value>
<comment>UI Automation localized control type of a cell.</comment>
</data>
<data name="RowNumber" xml:space="preserve">
<value>Wiersz {0}</value>
<comment>UI Automation name of a row; {0} is the one-based row number.</comment>
</data>
<data name="Row" xml:space="preserve">
<value>Wiersz</value>
<comment>UI Automation name of a row whose index is not known.</comment>
</data>
</root>

24 changes: 24 additions & 0 deletions src/Strings/pt-BR/WinUI.TableView.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,28 @@
<data name="SortGroupsByValue" xml:space="preserve">
<value>Ordenar grupos por valor</value>
</data>
<data name="TableViewControlType" xml:space="preserve">
<value>exibição de tabela</value>
<comment>UI Automation localized control type of the TableView.</comment>
</data>
<data name="ColumnHeaderControlType" xml:space="preserve">
<value>cabeçalho de coluna</value>
<comment>UI Automation localized control type of a column header.</comment>
</data>
<data name="RowHeaderControlType" xml:space="preserve">
<value>cabeçalho de linha</value>
<comment>UI Automation localized control type of a row header.</comment>
</data>
<data name="CellControlType" xml:space="preserve">
<value>célula</value>
<comment>UI Automation localized control type of a cell.</comment>
</data>
<data name="RowNumber" xml:space="preserve">
<value>Linha {0}</value>
<comment>UI Automation name of a row; {0} is the one-based row number.</comment>
</data>
<data name="Row" xml:space="preserve">
<value>Linha</value>
<comment>UI Automation name of a row whose index is not known.</comment>
</data>
</root>
24 changes: 24 additions & 0 deletions src/Strings/ru-RU/WinUI.TableView.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,28 @@
<data name="SortGroupsByValue" xml:space="preserve">
<value>Сортировать группы по значению</value>
</data>
<data name="TableViewControlType" xml:space="preserve">
<value>представление таблицы</value>
<comment>UI Automation localized control type of the TableView.</comment>
</data>
<data name="ColumnHeaderControlType" xml:space="preserve">
<value>заголовок столбца</value>
<comment>UI Automation localized control type of a column header.</comment>
</data>
<data name="RowHeaderControlType" xml:space="preserve">
<value>заголовок строки</value>
<comment>UI Automation localized control type of a row header.</comment>
</data>
<data name="CellControlType" xml:space="preserve">
<value>ячейка</value>
<comment>UI Automation localized control type of a cell.</comment>
</data>
<data name="RowNumber" xml:space="preserve">
<value>Строка {0}</value>
<comment>UI Automation name of a row; {0} is the one-based row number.</comment>
</data>
<data name="Row" xml:space="preserve">
<value>Строка</value>
<comment>UI Automation name of a row whose index is not known.</comment>
</data>
</root>
24 changes: 24 additions & 0 deletions src/Strings/sk-SK/WinUI.TableView.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,28 @@
<data name="SortGroupsByValue" xml:space="preserve">
<value>Zoradiť Skupiny Podľa Hodnoty</value>
</data>
<data name="TableViewControlType" xml:space="preserve">
<value>zobrazenie tabuľky</value>
<comment>UI Automation localized control type of the TableView.</comment>
</data>
<data name="ColumnHeaderControlType" xml:space="preserve">
<value>hlavička stĺpca</value>
<comment>UI Automation localized control type of a column header.</comment>
</data>
<data name="RowHeaderControlType" xml:space="preserve">
<value>hlavička riadka</value>
<comment>UI Automation localized control type of a row header.</comment>
</data>
<data name="CellControlType" xml:space="preserve">
<value>bunka</value>
<comment>UI Automation localized control type of a cell.</comment>
</data>
<data name="RowNumber" xml:space="preserve">
<value>Riadok {0}</value>
<comment>UI Automation name of a row; {0} is the one-based row number.</comment>
</data>
<data name="Row" xml:space="preserve">
<value>Riadok</value>
<comment>UI Automation name of a row whose index is not known.</comment>
</data>
</root>
24 changes: 24 additions & 0 deletions src/Strings/zh-CN/WinUI.TableView.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,28 @@
<data name="SortGroupsByValue" xml:space="preserve">
<value>按值排序分组</value>
</data>
<data name="TableViewControlType" xml:space="preserve">
<value>表格视图</value>
<comment>UI Automation localized control type of the TableView.</comment>
</data>
<data name="ColumnHeaderControlType" xml:space="preserve">
<value>列标题</value>
<comment>UI Automation localized control type of a column header.</comment>
</data>
<data name="RowHeaderControlType" xml:space="preserve">
<value>行标题</value>
<comment>UI Automation localized control type of a row header.</comment>
</data>
<data name="CellControlType" xml:space="preserve">
<value>单元格</value>
<comment>UI Automation localized control type of a cell.</comment>
</data>
<data name="RowNumber" xml:space="preserve">
<value>第 {0} 行</value>
<comment>UI Automation name of a row; {0} is the one-based row number.</comment>
</data>
<data name="Row" xml:space="preserve">
<value>行</value>
<comment>UI Automation name of a row whose index is not known.</comment>
</data>
</root>
24 changes: 24 additions & 0 deletions src/Strings/zh-TW/WinUI.TableView.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,28 @@
<data name="SortGroupsByValue" xml:space="preserve">
<value>依值排序群組</value>
</data>
<data name="TableViewControlType" xml:space="preserve">
<value>表格檢視</value>
<comment>UI Automation localized control type of the TableView.</comment>
</data>
<data name="ColumnHeaderControlType" xml:space="preserve">
<value>欄標題</value>
<comment>UI Automation localized control type of a column header.</comment>
</data>
<data name="RowHeaderControlType" xml:space="preserve">
<value>列標題</value>
<comment>UI Automation localized control type of a row header.</comment>
</data>
<data name="CellControlType" xml:space="preserve">
<value>儲存格</value>
<comment>UI Automation localized control type of a cell.</comment>
</data>
<data name="RowNumber" xml:space="preserve">
<value>第 {0} 列</value>
<comment>UI Automation name of a row; {0} is the one-based row number.</comment>
</data>
<data name="Row" xml:space="preserve">
<value>列</value>
<comment>UI Automation name of a row whose index is not known.</comment>
</data>
</root>
Loading
Loading