Define "prepare credential requests" algorithm by marcoscaceres · Pull Request #420 · w3c-fedid/digital-credentials

marcoscaceres · 2025-12-16T10:28:17Z

Added the "prepare credential requests" algorithm, detailing validation of each request, handling of unsupported protocols, error propagation, and abort signal integration.

Closes #432
Closes #249
Closes #220
Closes #207
Closes #159

The following tasks have been completed:

Modified Web platform tests

Implementation commitment:

WebKit - Digital Credential: CredentialRequestCoordinator can remain non-Idle if AbortSignal races with picker result WebKit/WebKit#56489
Chromium (link to issue)
Gecko (link to issue)

Documentation and checks

Preview | Diff

marcoscaceres · 2026-01-20T01:57:31Z

Blocked on tests.

…if AbortSignal races with picker result rdar://163295172 https://bugs.webkit.org/show_bug.cgi?id=305363 Reviewed by Pascoe. Fix race and crash in CredentialRequestCoordinator by settling promises only after picker teardown and safely handling abort reasons. Ensure credential requests always settle after the picker UI has fully torn down. This change: - Defers promise settlement until the picker dismiss callback fires - Better handles aborts during presentation and teardown - Avoids capturing unprotected JSValues across async boundaries - Keeps coordinator state transitions more consistent (with better checks) It also more closely follows the spec: w3c-fedid/digital-credentials#420 w3c-fedid/digital-credentials#419 * LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html: * Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp: (WebCore::CredentialRequestCoordinator::PickerStateGuard::PickerStateGuard): (WebCore::CredentialRequestCoordinator::PickerStateGuard::~PickerStateGuard): (WebCore::CredentialRequestCoordinator::setState): (WebCore::CredentialRequestCoordinator::prepareCredentialRequest): (WebCore::CredentialRequestCoordinator::handleDigitalCredentialsPickerResult): (WebCore:: const): (WebCore::CredentialRequestCoordinator::dismissPickerAndSettle): (WebCore::CredentialRequestCoordinator::abortPicker): (WebCore::CredentialRequestCoordinator::contextDestroyed): (WebCore::CredentialRequestCoordinator::~CredentialRequestCoordinator): (): Deleted. (WebCore::CredentialRequestCoordinator::presentPicker): Deleted. (WebCore::CredentialRequestCoordinator::finalizeDigitalCredential): Deleted. * Source/WebCore/Modules/identity/CredentialRequestCoordinator.h: * Source/WebCore/Modules/identity/DigitalCredential.cpp: (WebCore::DigitalCredential::discoverFromExternalSource): * Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: Canonical link: https://commits.webkit.org/305868@main

index.html

hlflanagan · 2026-01-22T14:44:09Z

Discussed in 21 January 2026 Series B call

Copilot

Pull request overview

Defines the “prepare credential requests” algorithm for the credential request coordinator and wires it into the DigitalCredential get/create integration flow.

Changes:

Adds a detailed “Prepare credential requests” algorithm, including request filtering, protocol checks, validation, error propagation, and abort integration.
Updates [[DiscoverFromExternalSource]] and [[Create]] to create/return a promise and delegate to the new preparation algorithm.
Updates WebIDL around DigitalCredential.protocol by introducing a DigitalCredentialProtocol typedef and changing the attribute type accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

index.html

Copilot · 2026-02-03T10:54:15Z

@marcoscaceres I've opened a new pull request, #459, to work on those changes. Once the pull request is ready, I'll request review from you.

index.html

marcoscaceres · 2026-02-26T07:44:42Z

index.html

+          <li>If the [=user agent=] does not allow |protocol|,
+          [=iteration/continue=].
+          </li>
+          <li>Let |validatedRequest| be the result of validating |request|'s


marcoscaceres · 2026-02-26T07:44:53Z

index.html

+              </p>
+            </aside>
+          </li>
+          <li>If |validatedRequest| is an [=exception=]:


Suggested change

<li>If |validatedRequest| is an [=exception=]:

<li>If |validatedRequestOrException| is an [=exception=]:

marcoscaceres · 2026-02-26T07:45:11Z

index.html

+          <li>If |validatedRequest| is an [=exception=]:
+            <ol>
+              <li>[=credential request coordinator/Complete credential request
+              with=] |promise| and |validatedRequest|.


marcoscaceres · 2026-02-26T07:45:22Z

index.html

+              </li>
+            </ol>
+          </li>
+          <li>[=list/Append=] |validatedRequest| to |validatedRequests|.


marcoscaceres · 2026-02-26T07:57:42Z

index.html

      To <dfn data-dfn-for="credential request coordinator" data-local-lt=
      "complete credential request with">complete credential request with
      error</dfn> given a {{Promise}} |promise:Promise| and (a JavaScript
      Value) |error|:


Suggested change

To <dfn data-dfn-for="credential request coordinator">reject request with</dfn> a (JavaScript Value) |error| and a {{Promise}} |promise:Promise|:

marcoscaceres · 2026-02-26T07:58:45Z

index.html

+      </li>
+    </ol>
    <h3>
      Complete credential request with error


Suggested change

Complete credential request with error

Reject request with error

marcoscaceres mentioned this pull request Jan 7, 2026

Fixup algorithms in credential creation and request steps. #418

Merged

9 tasks

marcoscaceres force-pushed the prepare branch from 0110b09 to 0aa302c Compare January 8, 2026 07:33

marcoscaceres mentioned this pull request Jan 9, 2026

Update get procedure for when UA does not support a protocol #432

Open

MasterKale mentioned this pull request Jan 9, 2026

Add guidance on how to handle multiple presentation request entries #249

Closed

9 tasks

marcoscaceres force-pushed the prepare branch from d02002d to bb35ade Compare January 13, 2026 01:02

marcoscaceres marked this pull request as ready for review January 13, 2026 12:50

marcoscaceres requested a review from a team as a code owner January 13, 2026 12:50

marcoscaceres mentioned this pull request Jan 13, 2026

Digital Credential: CredentialRequestCoordinator can remain non-Idle if AbortSignal races with picker result WebKit/WebKit#56489

Merged

marcoscaceres force-pushed the prepare branch from bb35ade to 0222f65 Compare January 13, 2026 23:22

marcoscaceres added agenda+ Add to the weekly agenda BLOCKED labels Jan 20, 2026

jschanck reviewed Jan 21, 2026

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Show resolved Hide resolved

marcoscaceres mentioned this pull request Jan 21, 2026

Change from Registry to Protocols #401

Merged

9 tasks

mohamedamir reviewed Jan 21, 2026

View reviewed changes

index.html Outdated Show resolved Hide resolved

mohamedamir reviewed Jan 21, 2026

View reviewed changes

index.html Outdated Show resolved Hide resolved

colelao mentioned this pull request Jan 22, 2026

WIP Fix Screen Wake Lock in Site Isolation WebKit/WebKit#57011

Closed

marcoscaceres force-pushed the prepare branch from d11d30f to 14054cb Compare January 28, 2026 08:26

marcoscaceres requested review from jschanck and mohamedamir January 28, 2026 08:40

marcoscaceres force-pushed the prepare branch from 35336be to 0b7552c Compare February 3, 2026 04:07

marcoscaceres requested review from Copilot and removed request for jschanck February 3, 2026 04:35

Copilot started reviewing on behalf of marcoscaceres February 3, 2026 04:35 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

index.html Show resolved Hide resolved

Copilot AI mentioned this pull request Feb 3, 2026

[WIP] WIP Address feedback on prepare credential requests algorithm #459

Closed

5 tasks

marcoscaceres mentioned this pull request Feb 4, 2026

Manage abort signal's lifecycle #460

Open

marcoscaceres removed the agenda+ Add to the weekly agenda label Feb 4, 2026

marcoscaceres force-pushed the prepare branch from 876e8fb to e0bf221 Compare February 4, 2026 03:04

Copilot AI mentioned this pull request Feb 5, 2026

Add algorithm signature for 'prepare credential requests' #461

Merged

marcoscaceres force-pushed the prepare branch from e0bf221 to 5f800a9 Compare February 5, 2026 10:48

marcoscaceres removed the BLOCKED label Feb 12, 2026

marcoscaceres force-pushed the prepare branch from 60bfb2f to 8c172e7 Compare February 23, 2026 03:59

Define "prepare credential requests" algorithm

f520d19

marcoscaceres force-pushed the prepare branch from 8c172e7 to f520d19 Compare February 23, 2026 04:02

Remove abort algo. Moved

fca972d

marcoscaceres added the agenda+ Add to the weekly agenda label Feb 23, 2026

marcoscaceres commented Feb 26, 2026

View reviewed changes

index.html Outdated Show resolved Hide resolved

Apply suggestion from @marcoscaceres

bba0a19

marcoscaceres requested a review from timcappalli February 26, 2026 07:38

marcoscaceres commented Feb 26, 2026

View reviewed changes

	<li>Let \|validatedRequest\| be the result of validating \|request\|'s
	<li>Let \|validatedRequestOrException\| be the result of validating \|request\|'s

	<li>If \|validatedRequest\| is an [=exception=]:
	<li>If \|validatedRequestOrException\| is an [=exception=]:

	with=] \|promise\| and \|validatedRequest\|.
	with error=] passing \|promise\| and \|validatedRequestOrException\|.

	<li>[=list/Append=] \|validatedRequest\| to \|validatedRequests\|.
	<li>[=list/Append=] \|validatedRequestOrException\| to \|validatedRequests\|.


	To <dfn data-dfn-for="credential request coordinator">reject request with</dfn> a (JavaScript Value) \|error\| and a {{Promise}} \|promise:Promise\|:

	Complete credential request with error
	Reject request with error

Conversation

marcoscaceres commented Dec 16, 2025 • edited by pr-preview bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcoscaceres commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hlflanagan commented Jan 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 3, 2026

Uh oh!

Uh oh!

marcoscaceres Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

marcoscaceres Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

marcoscaceres Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

marcoscaceres Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

marcoscaceres Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

marcoscaceres Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marcoscaceres commented Dec 16, 2025 •

edited by pr-preview bot

Loading