Add "Abort the credential request" algorithm#462
Open
marcoscaceres wants to merge 4 commits intomainfrom
Open
Conversation
marcoscaceres
force-pushed
the
abort_handler
branch
from
f9f9b63 to
ece9b7f
Compare
mohamedamir
reviewed
Feb 4, 2026
mohamedamir
reviewed
Feb 4, 2026
mohamedamir
reviewed
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the "Abort the credential request" algorithm to handle cleanup and promise rejection when a credential request needs to be aborted. The PR specifically addresses issue #435 regarding execution context destruction by implementing monitoring for when a document becomes non-fully active and the associated abort logic.
Changes:
- Added an algorithm to monitor when a document stops being fully active and trigger abort
- Implemented the "abort the credential request" algorithm to handle state transitions and UI cleanup
- Defined proper error handling flow through the existing "complete credential request with error" algorithm
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timcappalli
approved these changes
Feb 17, 2026
This algorithm is used to handle aborting the credential request when: * The associated AbortSignal is aborted. * The document becomes non-fully active. * The iframe handling the request is destroyed.
Co-authored-by: Mohamed Amir Yosef <[email protected]>
Co-authored-by: Mohamed Amir Yosef <[email protected]>
marcoscaceres
force-pushed
the
abort_handler
branch
from
2cf4494 to
c0da0d4
Compare
mohamedamir
approved these changes
Feb 26, 2026
Contributor
mohamedamir
left a comment
mohamedamir
left a comment
There was a problem hiding this comment.
Thanks a lot!
Look great!
Collaborator
Author
|
@hlflanagan @wseltzer, we think this is ready to merge. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #435
This algorithm is used to handle aborting the credential request when:
The following tasks have been completed:
Implementation commitment:
Documentation and checks
Preview | Diff