Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "wide and deep" instead of "broad and horizontal". #229

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

fantasai
Copy link
Contributor

@fantasai fantasai commented Jan 10, 2025

  • Use the term "wide" rather than "broad", since that's the term we use elsewhere. (I like the way "broad" reads slightly better, but I think the consistency is more helpful to the community.)
  • Add the term "deep", since we perform (and value) deep reviews of our specs as well as "wide" reviews: doing both is a key aspect of our ability to do "thorough" review.
  • Drop the jargon term "horizontal", which is merely a part of "wide review" that currently has an encoded procedure in our guidebook.
  • Restructure the sentence to avoid using the word "ensure" twice.

Fixes #229

- Use the term "wide" rather than "broad", since that's the term we use elsewhere. (I like the way "broad" reads slightly better, but I think the consistency is more helpful to the community.)
- Add the term "deep", since we perform and value deep reviews of our specs as well as "wide" reviews: doing both is a key aspect of our ability to do "thorough" review.
- Drop the jargon term "horizontal", which is merely a part of "wide review" that currently has an encoded procedure.
- Restructure the sentence to avoid using the word "ensure" twice.
@fantasai fantasai added the Project Vision Vision and Principles label Jan 10, 2025
@cwilso
Copy link
Collaborator

cwilso commented Jan 12, 2025

I think part of this is a significant regression in meaning.

"Horizontal review" might seem jargonistic, but it has a very specific meaning: review against a set of fundamental principles or perspectives, rather than just wide review by any who might be interested. This isn't just a part of wide review: it's an intentional choice to invest in a consistent set of fundamental technical attributes. (This term isn't just a W3C term, either.)

I'm somewhat ambivalent about the use of "wide" rather than "broad", and do appreciate the revision to avoid using the verb ensure twice. I'll suggest some changes to pick up the editorial improvements, but if you are set on this removing horizontal, this needs to be reviewed as an issue.

@cwilso cwilso self-requested a review January 12, 2025 02:36
Copy link
Collaborator

@cwilso cwilso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After pondering for several minutes and trying other approaches to be sure, I like your framing of the sentence best; however, as previously commented I'm not okay with removing horizontal review (if anything, we should expand the meaning), and I think "deep" is clearly indicated by the set of fundamental attributes listed, particularly architectural integrity.

@tantek tantek merged commit 2203221 into main Feb 14, 2025
4 checks passed
@fantasai fantasai deleted the fantasai-deep-1 branch February 14, 2025 23:39
@fantasai
Copy link
Contributor Author

Just confirming that @cwilso cleared his edits here with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project Vision Vision and Principles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants