-
Notifications
You must be signed in to change notification settings - Fork 27
Discoverable destinations #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+72
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwolberg
approved these changes
Nov 8, 2025
abhina-kumar
approved these changes
Nov 9, 2025
github-actions bot
added a commit
that referenced
this pull request
Nov 9, 2025
SHA: 31055aa Reason: push, by abhina-kumar Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 9, 2025
SHA: 31055aa Reason: push, by abhina-kumar Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 9, 2025
SHA: 31055aa Reason: push, by abhina-kumar Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 9, 2025
SHA: 31055aa Reason: push, by abhina-kumar Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 9, 2025
SHA: 31055aa Reason: push, by abhina-kumar Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
- I think shortname 'adapt-destinations' is AOK
- directory name within the repo 'destinations' - Since it is the adapt
repo, this seems fine to me. Let me know why you think it may not be OK.
- occurrences of 'well-known' in the doc: I agree that 'frequently
accessed' is more cogent, but we can leave them for now.
…On Thu, Nov 6, 2025 at 21:31 Matthew Tylee Atkinson < ***@***.***> wrote:
Changes made:
- Rename the destinations explainer to 'discoverable-destinations.md.'
- Rename the proposal within the explainer.
- Rename the proposal within the destinations respec document.
- Rename the document (within the intro section) from 'specification'
to 'best practices document'.
Notes/questions for the group:
- The shortname for the destinations respec (best practices) doc is
currently set to 'adapt-destinations' - do we want that?
- The directory name within the repo is 'destinations' - do we want
that? Should we harmonise them?
- There are still a few occurrences of 'well-known' in the
destinations best practice doc that need to be replaced by something like
'frequently accessed' or similar (or not; we could leave them for now).
Explainer preview:
https://github.com/w3c/adapt/tree/discoverable-destinations/explainers/discoverable-destinations.md
Best practices doc preview:
https://raw.githack.com/w3c/adapt/discoverable-destinations/destinations/index.html
------------------------------
You can view, comment on, or merge this pull request online at:
#328
Commit Summary
- c458604
<c458604>
Rename within the explainer
- f5ad012
<f5ad012>
Rename explainer
- b7782af
<b7782af>
Almost all renames within destinations doc
- 10a7b55
<10a7b55>
Rename destinations doc (within section) from spec to best practices doc
File Changes
(2 files <https://github.com/w3c/adapt/pull/328/files>)
- *M* destinations/index.html
<https://github.com/w3c/adapt/pull/328/files#diff-b4888dc728cc318fbcfdd134c3bc05f38060153b2a998024b05a51ea9b940fa7>
(58)
- *R* explainers/discoverable-destinations.md
<https://github.com/w3c/adapt/pull/328/files#diff-89206b37dbdf0acba25d85d678e0653faa8c6fc7bfb029988b27704ab98d92d1>
(86)
Patch Links:
- https://github.com/w3c/adapt/pull/328.patch
- https://github.com/w3c/adapt/pull/328.diff
—
Reply to this email directly, view it on GitHub
<#328>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPZJOQMG6CYNVVCPBVYN5T33OO2XAVCNFSM6AAAAACLLXRUJOVHI2DSMVQWIX3LMV43ASLTON2WKOZTGU4TOMRZGQ4DINQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
Notes/questions for the group:
Explainer preview: https://github.com/w3c/adapt/tree/discoverable-destinations/explainers/discoverable-destinations.md
Best practices doc preview: https://raw.githack.com/w3c/adapt/discoverable-destinations/destinations/index.html