-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add “expandable region” pattern #3251
base: main
Are you sure you want to change the base?
Conversation
Heya @mcking65, here’s an initial PR for the expandable region pattern. There are a number of linting errors I’ll need to resolve, but I may not have time to do that before I head out early next week. @howard-e, could you let me know if the preview build failure is being caused by those linting errors? If so, I’ll do my best to get those fixed before I leave. In the meantime, please feel free to review and share feedback for this standalone Codepen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howard-e, could you let me know if the preview build failure is being caused by those linting errors? If so, I’ll do my best to get those fixed before I leave.
@adampage nope, the linting isn't the culprit here.
The preview generation builder expects files and folders to be in a very specific structure, seemingly to avoid any conflicts or invalid data-to-template attachments. One of those is having a defined *-pattern.html
in the immediate sub-directory of the /patterns
directory. So the expectation would be to have a /content/patterns/expandable-region/expandable-region-pattern.html
(along with the references to it).
This is obviously a pain point to newer contributors (apologies) so there is an existing issue I'm hoping to get to shortly to document these particularities (or to revise altogether).
But that restriction can be ignored, which I have in w3c/wai-aria-practices#395 to allow this to successfully build. In this approach however, it won’t include the "WAI" wrapper around it, just the html, so I’ve already prepared a PR to remove it when this rename is done.
content/patterns/expandable-region/examples/expandable-region.html
Outdated
Show resolved
Hide resolved
…html Co-authored-by: Howard Edwards <[email protected]>
Co-authored-by: Howard Edwards <[email protected]>
I’m suspicious of these HTML linting errors. 🤔
|
Resolves #3215.
WAI Preview Link (Last built on Wed, 19 Mar 2025 20:26:56 GMT).