Editorial: Make specURLs consistent and fix some respec warnings #2305
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Looks good to me except for one minor nit, I think a change got snuck in here which also is in #2288
html-aam/index.html
Outdated
| @@ -16676,7 +16710,7 @@ <h3>Acknowledgments</h3> | |||
| Add listing of individuals who have providing meaningful | |||
| contributions through commenting that have impacted the specification. | |||
| --></div> | |||
| <div data-include="https://rawgit.com/w3c/aria/master/../common/acknowledgements/funders.html" data-include-replace="true"></div> | |||
| <div data-include="../common/acknowledgements/funders.html" data-include-replace="true"></div> | |||
There was a problem hiding this comment.
This change is also landing here: https://github.com/w3c/aria/pull/2288/files#diff-5c3c8936e81538898c83ae11f5271e9ae9324925713a3b03aca58cbd2a3c3014
so it might cause a conflict
There was a problem hiding this comment.
I meant to approve but I accidentally commented -- the only thing is: #2305 (comment)
spectranaut
changed the title
|
Hi @spectranaut <div data-include="https://rawgit.com/w3c/aria/master/../common/acknowledgements/funders.html" data-include-replace="true"></div>I think we should replace it with I've replaced it here, left https://github.com/w3c/aria/pull/2288/files#diff-5c3c8936e81538898c83ae11f5271e9ae9324925713a3b03aca58cbd2a3c3014 intact. |
|
@daniel-montalvo is this still relevant? If so, could you update it to resolve the merge conflicts? |
|
Thanks @pkra for having a look at this. Resolved conflicts. I'd like to take a closer look at this to see if is actually worth merging. I'll put this as draft for now and change it back when I'm done. Best. |
pkra
added
the
editorial
|
@daniel-montalvo this is marked as a draft. Is this ready? |
|
Couldn’t get to this yet, sorry.
…--
Daniel Montalvo Charameli
Accessibility Specialist
W3C/WAI
From: Peter Krautzberger ***@***.***>
Sent: Sunday, February 9, 2025 7:09 PM
To: w3c/aria ***@***.***>
Cc: Daniel Montalvo ***@***.***>; Mention ***@***.***>
Subject: Re: [w3c/aria] Editorial: Make specURLs consistent and fix some respec warnings (PR #2305)
@daniel-montalvo <https://github.com/daniel-montalvo> this is marked as a draft. Is this ready?
—
Reply to this email directly, view it on GitHub <#2305 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALYFOWUL6P67X2FZLFGFGBL2O6KSXAVCNFSM6AAAAABMCWK2WOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBWGQ2DGMZVGY> .
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Should be ready now. +1 to @pkra 's suggestion. Also, a future project would be to try to put respec config in separate files (different than the index.html) for easier maintenance. |
SHA: 5593255 Reason: push, by pkra Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@daniel-montalvo the following two merge actions failed - could you take a look? https://github.com/w3c/aria/actions/runs/13290698310, https://github.com/w3c/aria/actions/runs/13290698329 |
Preview | Diff