-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifications for HTML's autocomplete and aria-autocomplete #2350
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a suggested change for a spelling error, this looks okay to ship IMO.
thank you @MelSumner. Co-authored-by: Melanie Sumner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 These clarifications are helpful.
Closes #2337
autocomplete
mapping for theform
element (it doesn't map directly to the form element, but rather owned form controls will expose a supports autocompletion mapping, or not).aria-autocomplete=" [ valid value ] "
andautocomplete=off
together, but that forautocomplete=" [ valid value ] "
andaria-autocomplete="[ valid value ] "
, UA behavior should win out.not sure how much more detail needs to be provided, as attempting to do so felt like treading into repeating what is already defined in each spec for these attributes (html / aria).
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.