[css-view-transitions-1] Replace 'snapshot viewport' with 'snapshot root' #8324
Conversation
| This includes the scrollbars, but does not include the URL bar, as web content never appears in that area. | ||
| </figcaption> | ||
| </figure> | ||
|
|
||
| This means the snapshot canvas size is likely to be consistent for the [=document element=]'s [=captured element/old image=] and [=captured element/new element=]. | ||
|
|
||
| The <dfn>snapshot viewport origin</dfn> refers to the start of the block and inline axes of the [=snapshot viewport=]. |
There was a problem hiding this comment.
This is used only in reference to transforms which AFAIK are always based on x,y running positive starting from the top-left.
| @@ -1210,7 +1210,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; | |||
|
|
|||
| 1. Set |height| to the current height of |capturedElement|'s [=new element=]'s [=border box=]. | |||
|
|
|||
| 1. Set |transform| to a transform that maps the |capturedElement|'s [=new element=]'s [=border box=] from document origin to its quad from the [=snapshot viewport origin=]. | |||
There was a problem hiding this comment.
I'm a bit confused by what was meant here so maybe I'm just misunderstanding but "its quad from the snapshot viewport origin" is what we're trying to compute here so it seems a bit circular.
I also think the "border box from document origin" is wrong if we were to load the page scrolled (since the snapshot viewport is effectively fixed but the document origin is pushed up by the scroll)...instead we want to go from the snapshot rect origin to "element's border box relative to the snapshot rect origin".
|
@vmpstr @khushalsagar as FYI |
bokand
changed the title
css-view-transitions-1/Overview.bs
Outdated
| @@ -1210,7 +1210,7 @@ urlPrefix: https://html.spec.whatwg.org/multipage/rendering.html; type: dfn; | |||
|
|
|||
| 1. Set |height| to the current height of |capturedElement|'s [=new element=]'s [=border box=]. | |||
|
|
|||
| 1. Set |transform| to a transform that maps the |capturedElement|'s [=new element=]'s [=border box=] from document origin to its quad from the [=snapshot viewport origin=]. | |||
| 1. Set |transform| to a transform that maps the [=snapshot root origin=] to the top-left corner of the |capturedElement|'s [=new element=]'s [=border box=]. | |||
There was a problem hiding this comment.
I'm trying to think of clearer ways to word this. What about:
- Set |transform| to a transform that would place |capturedElement|'s [=new element=]'s [=border box=] in its current visual position, from the [=snapshot root origin=].
Although I'm happy to go with what you have here.
There was a problem hiding this comment.
Settled on:
- Set |transform| to a transform that would map |capturedElement|'s [=new element=]'s [=border box=] from the [=snapshot root origin=] to its current visual position.
Also updated the equivalent prose in the setup phase to match.
|
Thanks for the review! |
[css-view-transitions-1] Replace 'snapshot viewport' with 'snapshot root'
"Viewport" is already a heavily overloaded term and this rect isn't really a "viewport" in most senses so rename it to "snapshot root" to avoid confusion.
Also some minor improvements around its origin and how transforms are computed.
See also: #8070, #7859