Add protected graph container null context test.#582
Merged
Conversation
dlongley
approved these changes
Dec 6, 2023
gkellogg
approved these changes
Dec 6, 2023
davidlehn
force-pushed
the
add-graph-container-tests
branch
from
626350a to
385d101
Compare
Contributor
Author
pchampin
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test for a protected
@graph@containerproperty that nullifies it's@context. This is similar to a pattern found in the VC Data Model 2.0 context. There are other test variations of context nullification, graph properties, and protection rules, etc, but there doesn't seem to be one with this combination. jsonld.js was failing this test but other implementations pass.Are other variations of this test needed? It looks like most base features are covered, but perhaps tricky combinations of features might expose edge case issues. Help needed.
See:
w3c/vc-data-model#1373