Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: address xref issue #394

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Meta: address xref issue #394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,8 +996,8 @@ <h2>
creation of the {{ArrayBuffer}} object are re-thrown.
</p>
<p data-cite="encoding">
The <dfn>json()</dfn> method steps are to return the result of <a>parsing JSON bytes to a
JavaScript value</a> given [=this=]'s [=bytes=].
The <dfn>json()</dfn> method steps are to return the result of [=parse JSON bytes to a
JavaScript value|parsing JSON bytes to a JavaScript value=] given [=this=]'s [=bytes=].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While approving, I thought this should just work on ReSpec too? cc @sidvishnoi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's relatively new that it works in Bikeshed. As this doesn't really block the other PRs in terms of preview or reviewability, I can wait a bit to see what @sidvishnoi says.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on textVariations (based on Bikeshed itself, but maybe needs some updates now). It can only do these transformations at the end of string (if it was "do the parse", it could have become "do the parsing").
Not planning to support transformations at the start any time soon though.

</p>
<p data-cite="encoding">
The <dfn>text()</dfn> method steps are to return the result of running <a>UTF-8 decode</a>
Expand Down
Loading