Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links and remove obsolete notes. #27

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Fix broken links and remove obsolete notes. #27

merged 1 commit into from
Apr 1, 2023

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Mar 28, 2023 •
edited by pr-preview bot
Loading

@gkellogg gkellogg added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Mar 28, 2023
@gkellogg
Copy link
Member Author

Draft until other PRs are merged and this is re-checked.

@gkellogg gkellogg requested review from hartig and domel March 28, 2023 22:30
@hartig
Copy link
Contributor

hartig commented Mar 29, 2023

Gregg, why are these editor notes / questions obsolete now?

@gkellogg
Copy link
Member Author

Gregg, why are these editor notes / questions obsolete now?

The notes are related to duplicate term definitions, which is addressed in w3c/rdf-semantics#17. This PR presumes that those changes are made, but is in draft because it also depends on other parallel changes.

If it's clear that denote is defined in RDF Concepts and not RDF Semantics and those changes are made, then the purpose of the note has been fulfilled. The "ednote" class is there specifically to remind editors of things to attend to.

@gkellogg gkellogg mentioned this pull request Mar 29, 2023
Merged
@hartig
Copy link
Contributor

hartig commented Mar 29, 2023

Thanks for the clarification. I was not aware of w3c/rdf-semantics#17

@gkellogg gkellogg marked this pull request as ready for review March 31, 2023 16:58
@gkellogg gkellogg merged commit 05e5063 into main Apr 1, 2023
@gkellogg gkellogg deleted the broken-links branch April 1, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domel domel domel approved these changes

@hartig hartig hartig approved these changes

Assignees
No one assigned
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkellogg @hartig @domel