Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexical-to-value mapping is not a "partial mapping" #66

Open
hartig opened this issue Jan 9, 2025 · 15 comments · May be fixed by #77
Open

Lexical-to-value mapping is not a "partial mapping" #66

hartig opened this issue Jan 9, 2025 · 15 comments · May be fixed by #77

Comments

@hartig
Copy link

hartig commented Jan 9, 2025

This issue is about the following sentence in Sec.7 of RDF Semantics.

A datatype is understood to define a partial mapping, called the lexical-to-value mapping, from a lexical space (a set of character strings) to values.

This sentence is incorrect in the sense that, by the definition of the notion of a lexical-to-value mapping in RDF Concepts, it is not a partial mapping but a total mapping (or, simply, a function). The relevant part of the definition is that is says: "Each member of the lexical space is paired with ..."

Related to this issue, the following sentence (in the same paragraph as the one quoted above) is also not particularly accurate.

An ill-typed literal is one whose datatype IRI is recognized, but whose character string is assigned no value by the lexical-to-value mapping for that datatype.

To fix this issue, I suggest to change the first sentence quoted above as follows:

A datatype is understood to define a function, called the lexical-to-value mapping, from a lexical space (a set of character strings) to values.

And the second sentence quoted above may be changed as follows:

An ill-typed literal is one whose datatype IRI is recognized, but whose character string is not in the lexical space of the datatype identified by that IRI and, thus, is not in the domain of the lexical-to-value mapping of that datatype.

@afs
Copy link
Contributor

afs commented Jan 9, 2025

A datatype is understood to define a function, called the lexical-to-value mapping, from a lexical space (a set of character strings) to values.

Minor tweaking: maybe "character string" could be RDF strings). This avoids "character". An "RDF String" is a sequences of Unicode scale values -- all codepoints except the surrogates.

Unicode D76:
"Unicode scalar value: Any Unicode code point except high-surrogate and low-surrogate code points."

@pfps
Copy link
Contributor

pfps commented Jan 9, 2025

Yeah the wording needs to be improved. I think the best thing is to defer more to RDF Concepts.

@hartig
Copy link
Author

hartig commented Jan 9, 2025

Minor tweaking: maybe "character string" could be RDF strings).

While I agree, I see this as a separate issue because it is not only in this particular sentence. Instead, the term "character string" appears multiple times in the paragraph in which this sentence is.

@hartig
Copy link
Author

hartig commented Jan 9, 2025

Yeah the wording needs to be improved. I think the best thing is to defer more to RDF Concepts.

I agree. There is quite a bit of repetition here in terms of things that are already in RDF Concepts.

@afs
Copy link
Contributor

afs commented Jan 9, 2025

The paragraph also needs #64 which adds that rdf:dirLangString is an exception, along side rdf:langString.

afs added a commit that referenced this issue Jan 9, 2025
afs added a commit that referenced this issue Jan 24, 2025
@pfps pfps linked a pull request Jan 31, 2025 that will close this issue
pfps pushed a commit that referenced this issue Jan 31, 2025
@pfps
Copy link
Contributor

pfps commented Jan 31, 2025

The partial mapping of this issue has been fixed.

If there is anything remaining to be done, the title of the issue should be fixed. Otherwise the issue should be closed.

@hartig
Copy link
Author

hartig commented Jan 31, 2025

Usually we close the issue once the corresponding PR is merged.

What about the second (and directly related) part of my initial issue description? ("Related to this issue, the following sentence ...")

@pfps
Copy link
Contributor

pfps commented Jan 31, 2025

That's the issue. A PR to close the "partial mapping" problem has been merged that was created and merged because there was a separate issue on just this point. But the issue appears to have more in it than that. If it does, then the issue title should be changed to reflect the remaining outstanding point(s).

@hartig
Copy link
Author

hartig commented Feb 1, 2025

Which PR are you referring to? I assume it is #77 but that one is not merged yet. Was there another one?

I understand that the follow-up comments in this issue here mention some other things. Yet, the initial issue description mentions two points: the one to change "partial mapping" to "function" (or to "mapping") and the one about "character string is assigned no value". While PR #77 fixes the first one, the second one is not fixed by that PR (in it's current state). Do you want to do that in a separate PR or do you think it doesn't need to be addressed?

@afs
Copy link
Contributor

afs commented Feb 1, 2025

I've added the proposed text change to #77 as a commit. I can't make it a GH suggestion because it out of range of the text the commit changes.

@pfps
Copy link
Contributor

pfps commented Feb 1, 2025

Oops. My apologies. It looks as if I was confused as to which PR I had applied.

You are right, PR #77 is not applied yet.

I suppose I could add the other fix to the PR, if that seems reasonable.

@pfps
Copy link
Contributor

pfps commented Feb 1, 2025

@afs I don't see anything in PR #77 except the one-word change that I put in.

@afs
Copy link
Contributor

afs commented Feb 1, 2025

It's there now.

@pfps
Copy link
Contributor

pfps commented Feb 1, 2025

Oops again. It appears that you committed just before I did and then I couldn't figure out why my attempt to commit what I though you suggested in a comment was because I had to do some git magic on my machine to make the commits there look nicer so I force-pushed on top of your commit. But all should be OK now as the only change I made was to remove a couple of commas.

@afs
Copy link
Contributor

afs commented Feb 1, 2025

I haven't committed anything!
It might have been in a written-unsent comment that got sent later.
(GH editing has a memory and that can a bit odd moving between tabs on the same PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants