Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove partial in description of L2V #77

Merged
merged 2 commits into from
Feb 6, 2025
Merged

remove partial in description of L2V #77

merged 2 commits into from
Feb 6, 2025

Conversation

pfps
Copy link
Contributor

@pfps pfps commented Jan 31, 2025 •
edited by pr-preview bot
Loading

Fixes #66

Preview | Diff

@pfps pfps requested review from doerthe and franconi January 31, 2025 15:29
@hartig hartig mentioned this pull request Feb 1, 2025
Closed
@afs
Copy link
Contributor

afs commented Feb 1, 2025

Add change at 778:

-    is assigned no value by the <a>lexical-to-value mapping</a>
-    for that datatype.</p>
+    is not in the lexical space of the datatype identified by that IRI and,
+    thus, is not in the domain of the <a>lexical-to-value mapping</a>
+    of that datatype.</p>

@pfps
Copy link
Contributor Author

pfps commented Feb 1, 2025

Done, except for a couple of commas.

@pfps
Copy link
Contributor Author

pfps commented Feb 1, 2025

@afs Does that fix all of #66?

@afs
Copy link
Contributor

afs commented Feb 1, 2025

The comment on this PR addresses the second of the two issue from @hartig.

The character string item is done by merged #67.

Also mentioned is rdf:dirLangString which is open-ATM #64 where there is a wording-style comment that I leave to the editors. I had tried to keep doc wording.

@pfps pfps added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Feb 6, 2025
@pfps pfps merged commit 6b0098e into main Feb 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afs afs afs approved these changes

@hartig hartig hartig approved these changes

@doerthe doerthe doerthe approved these changes

@franconi franconi Awaiting requested review from franconi

Assignees
No one assigned
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lexical-to-value mapping is not a "partial mapping"
4 participants
@pfps @afs @hartig @doerthe