-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOAD RDF document clarification (description section and definition section) #46
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a "slot"? These seem to be stand-ins for "(named) graph". If "(named) graph" can't be used yet, then this should be changed to --
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If "(named) graph" can be used, then this should be changed to --
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"slots" are described in section 2 and 4.2 Auxiliary Definitions.
The text "either in the default slot or in a named slot, if specified." in LOAD is unchanged from SPARQL 1.1 Update in the formal definition section.
A Graph Store is a mutable container of slots (one unnamed slot, and zero or more slots with name). Each slot holds an immutable graph. Update is "replace graph in slot by by another graph", preserving the container.
A dataset is strictly immutable, just like graphs aren't mutable.
The spec is a bit weak in places:
but it is the same Graph Store with different contents.
See the note in 4.2 Auxiliary Definitions that mentions to punning on "Graph Store" and "RDF Dataset".
This could be cleared up (but not this PR!).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. I should have looked to the pr-preview where it's much clearer why "slots" are being discussed.