Changed the proofPurpose range in the vocabulary - issue 248 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iherman
requested review from
msporny,
Wind4Greg and
seabass-labrax
as code owners
iherman
added
bug
Wind4Greg
approved these changes
Mar 19, 2024
TallTed
suggested changes
Mar 19, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
@TallTed I have taken up all your comments for the diagram description text, and some more. Could you, please, review again? Thx. |
TallTed
suggested changes
Mar 20, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
Thanks for this, Ted! |
37 tasks
dlongley
approved these changes
Apr 23, 2024
msporny
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR implements the solution for issue #248, as detailed in #248 (comment). This means changing the vocabulary, as well as the corresponding diagram.
As usual, the automatic preview is useless for vocabulary changes; instead, reviewers should use the dedicated preview page.