Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the "MUST" for error conditions to be in sync with CID and DI #1587

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

iherman
Copy link
Member

@iherman iherman commented Jan 20, 2025

See discussion in w3c/vc-data-integrity#327 : the handling/reporting of errors should be consistent with the DI and CID specifications.

(See also w3c/cid#140).


Preview | Diff

Copy link
Contributor

@longpd longpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns all our references to this topic and should be approved. +1 for that.

@iherman
Copy link
Member Author

iherman commented Jan 22, 2025

The issue was discussed in a meeting on 2025-01-22

  • no resolutions were taken
View the transcript

4.3. Removed the "MUST" for error conditions to be in sync with CID and DI (pr vc-data-model#1587)

See github pull request vc-data-model#1587.

Ivan Herman: ok. we have time for one more.

Manu Sporny: we have a section on error conditions.
… it's optional to implement.
… but if they do implement it, we have some strong requirements around how they implement those errors.
… this change would not effect our current test suites since these aren't tested now because they are optional.
… so, if we reduce this from a MUST to a SHOULD to match the upstream RFC, this would not effect any implementers currently passing the test suite.

Ivan Herman: so...apparently we have a mixed approach across the specifications that use this text.

Dave Longley: +1 for consistency.

Ivan Herman: so this PR actually makes things sync up.
… whatever else we do, we need to be consistent.

Phillip Long: +1 for this PR.

Ivan Herman: comment on the PR if you'd like.
… any final comments?
… ok. I think we can close the meeting.
… brent should be back next time.
… bye all.


@msporny msporny merged commit b2f09c5 into main Jan 26, 2025
1 check passed
@msporny msporny deleted the error-handling-sync-with-di branch January 26, 2025 17:27
@msporny
Copy link
Member

msporny commented Jan 26, 2025

Editorial, multiple reviews, changes requested and made, no objections, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR2 editorial Purely editorial changes to the specification.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants