Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change for case where all fields are mandatory #2282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

goetsu
Copy link

@goetsu goetsu commented Mar 23, 2022

  • add information to clarfy that when all fields mandatory this technique is just a best pratice not a requirement
  • making test procedure applicable only when form contain both required and optional controls

Closes #1698
Closes #2357

- add information to clarfy that when all fields mandatory this technique is just a best pratice not a requirement
- making test procedure applicable only when form contain both required and optional controls
@bruce-usab
Copy link
Contributor

If merged, closes #1698

@patrickhlauke
Copy link
Member

@bruce-usab if you add that to the PR's description/first comment, github will do this automagically (I just edited it to that effect)

@bruce-usab
Copy link
Contributor

if you add that to the PR's description/first comment, github will do this automagically

Thanks! That was indeed the effect I was trying to invoke.

Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@bruce-usab
Copy link
Contributor

bruce-usab commented May 5, 2022

Closes #2357

Co-authored-by: Kenneth G. Franqueiro <[email protected]>
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for wcag2 failed.

Name Link
🔨 Latest commit a02e8a5
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/679cf2109b5aca0008f79ff2

Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the closing </p> Ken spotted

@mbgower
Copy link
Contributor

mbgower commented Feb 7, 2025

I'm a little leery of this change on its own. We've already spent quite a bit of time clarifying that the word "required" as used in Labels or Instructions means "needed".
So I'd like to pay a bit more attention to this technique and bring it in line with that, rather than this very simple change.

I'm also not sure I agree it is only a best practice.

@mbgower mbgower self-assigned this Feb 7, 2025
@bruce-usab
Copy link
Contributor

Discussed on backlog call 2/7 and @mbgower offered to make another pass. On call, had several examples where the context means there is no needed to mark fields as being required. Common example is login fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants