-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change for case where all fields are mandatory #2282
base: main
Are you sure you want to change the base?
Conversation
- add information to clarfy that when all fields mandatory this technique is just a best pratice not a requirement - making test procedure applicable only when form contain both required and optional controls
If merged, closes #1698 |
@bruce-usab if you add that to the PR's description/first comment, github will do this automagically (I just edited it to that effect) |
Thanks! That was indeed the effect I was trying to invoke. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Closes #2357 |
Co-authored-by: Kenneth G. Franqueiro <[email protected]>
❌ Deploy Preview for wcag2 failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the closing </p>
Ken spotted
I'm a little leery of this change on its own. We've already spent quite a bit of time clarifying that the word "required" as used in Labels or Instructions means "needed". I'm also not sure I agree it is only a best practice. |
Discussed on backlog call 2/7 and @mbgower offered to make another pass. On call, had several examples where the context means there is no needed to mark fields as being required. Common example is login fields. |
Closes #1698
Closes #2357