Skip to content

Tweak G13, on-input understanding, F37 #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
May 20, 2025
Merged

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Mar 21, 2025

  • in G13, as radio buttons/inputs would cause 2.1.1 Keyboard failures (as keyboard users are not able to explicitly select a radio button with the keyboard without triggering a change event, which would then lead to a form submission or page reload in these examples), changing the examples to a select and a set of toggle buttons
  • reformatting/cleanup of the markup for G13
  • in on-input understanding, replacing the mention of radio buttons with a select dropdown as well, for clarity/consistency (in this case, even the radio button example would be fine, but it may confuse matters)
  • in F37, add an extra note explicitly mentioning that radio buttons will still fail 2.1.1 even if they included a warning that satisfies 3.2.2

Closes #898

Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 2b1720a
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/682c9f04638d0b0008662df5
😎 Deploy Preview https://deploy-preview-4291--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

* in G13, as radio buttons/inputs would cause 2.1.1 Keyboard failures (as keyboard users are not able to explicitly select a radio button with the keyboard without triggering a change event, which would then lead to a form submission or page reload in these examples), changing the examples to a `select` and a set of toggle buttons
* reformatting/cleanup of the markup for G13
* in on-input understanding, replacing the mention of radio buttons with a select dropdown as well, for clarity/consistency (in this case, even the radio button example would be fine, but it may confuse matters)

Closes #898
@patrickhlauke patrickhlauke force-pushed the patrickhlauke-techniqueG13-tweak branch from 0087049 to 06b1c56 Compare March 21, 2025 14:23
@patrickhlauke patrickhlauke changed the title Tweak G13 Tweak G13 and on-input understanding Mar 21, 2025
@patrickhlauke
Copy link
Member Author

patrickhlauke commented Mar 21, 2025

Do we think we need some extra call-out/note in the actual 3.2.2 understanding, warning that a set of radio buttons that have an onchange handler can still end up causing a 2.1.1 Keyboard failure? or is that a bit too specific?

Alternatively, might be worth also revisiting https://www.w3.org/WAI/WCAG21/Techniques/failures/F37 which does seem to suggest that if a set of radio buttons has a warning, it would then not fail ... maybe squeezing in a note at the end there saying that while that will then pass On Input, it will then fail Keyboard even with that preceding warning

EDIT: done

@patrickhlauke patrickhlauke self-assigned this Mar 21, 2025
@patrickhlauke patrickhlauke changed the title Tweak G13 and on-input understanding Tweak G13, on-input understanding, F37 Mar 21, 2025
@patrickhlauke patrickhlauke force-pushed the patrickhlauke-techniqueG13-tweak branch from a7beea8 to 6a31f3c Compare March 21, 2025 14:53
@mbgower mbgower assigned fstrr and unassigned patrickhlauke Mar 21, 2025
@dbjorge
Copy link
Contributor

dbjorge commented Apr 11, 2025

@patrickhlauke In the future, if you're going to accept editor reformattings as part of a PR, could you try to do the reformat first and commit it as a separate commit? Even if it's within the same PR, if you make it a separate commit from the actual content changes, it makes it much easier to review just the content on its own by filtering the first commit out of the diff in the GitHub files changed view.

@fstrr
Copy link
Contributor

fstrr commented Apr 17, 2025

Diff viewers for relevant pages:

@fstrr fstrr self-requested a review April 17, 2025 17:18
@patrickhlauke
Copy link
Member Author

@patrickhlauke In the future, if you're going to accept editor reformattings as part of a PR, could you try to do the reformat first and commit it as a separate commit? Even if it's within the same PR, if you make it a separate commit from the actual content changes, it makes it much easier to review just the content on its own by filtering the first commit out of the diff in the GitHub files changed view.

sure thing sorry. this came out extra messy as well once i merged and force-pushed stuff

@kfranqueiro
Copy link
Contributor

This was out of sync with main and had some large conflicts due to the reformatting. I have resolved this and tried to minimize the whitespace diff, so the diff view in the PR should be easier to read now. (Syncing with main also means the HTML diffs linked by Francis no longer flag things that this branch was out-of-date with.)

@patrickhlauke I am pretty sure I managed to preserve the actual changes in the PR, but I'd invite you to take a look to make sure. And I wanted to confirm, is it intentional that the note you added to F37 is nested only under the Tests section (i.e. not under Expected Results)?

@patrickhlauke
Copy link
Member Author

thanks @kfranqueiro - just checked, and it seems that all my fundamental changes are in there. and yes, i intended the note to be outside of the expected results ... but i could see a rationale for also moving it into that section...whatever makes most sense

@detlevhfischer
Copy link
Contributor

@patrickhlauke I was a bit confused about the assumption that the first example in G13 necessarily fails 2.1.1. If the row of radio inputs is meant to swap languages and loads content in another language when focussing=selecting the radio input, another page loads with focus the same input, and the next TAB or arrow key will then go to the next language and loads content in that language, again setting the focus to the radio input corresponding to that language, where is the 2.1.1 error? It seems a 2.1.1 error would only occur if you can never move beyond the selected language to other languages? I would be surprised if authors of G13 originally cooked up an example that was patently unusable for keyboard users...

Having said that, I agree that changing that to select based example is better.

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Apr 24, 2025

I was a bit confused about the assumption that the first example in G13 necessarily fails 2.1.1.

Oh for sure there's probably ways to NOT make it fail, with lots of extra "but since this then happens, users can - in a very convoluted way - still choose the right language" but it's so disruptive and broken as a concept (particularly if the user's focus gets thrown right back to the start of the page by default, and NOT also then moved directly to the radio button they just chose, etc) and requires so much extra context, that I thought it was probably much more digestible to pick a simpler, more common example that is less ambiguous/requiring of lots of other external factors.

same reason why i changed the multiple choice example ... IF the user is still able to navigate back to the previous step/slide and change the radio buttons, then yeah in a horrible way, it IS keyboard accessible. but if it's a type of quiz where they're not allowed to go back for some reason, then that fails. again, too much additional context needed, which I chose to just sidestep for clarity.

I was finding the sentence a little hard to wade through. I'm not entirely happy with the dashes, but it does make it easier to parse. Thoughts?
Copy link
Contributor

@mbgower mbgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickhlauke we didn't have support to incorporate this as it stood, so it's going to need to be put in front of folks again.
As such, I took the opportunity to do trivial word-smithing -- which I should have done as a batch instead of a bunch of tiny commits, sorry!

I incorporated them with the idea you can read it through in its updated form and we can iterate until it reads more smoothly. Hope this is friendly. I wouldn't normally do it this way, but just because we need to loop back again on this I was trying to expedite.

@kfranqueiro
Copy link
Contributor

kfranqueiro commented May 6, 2025

As such, I took the opportunity to do trivial word-smithing -- which I should have done as a batch instead of a bunch of tiny commits, sorry!

If you want to read just Mike's changes: 0ff6c0a...90dd368

Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed previously and also on backlog call 5/16. It was helpful to have the changes consolidated.

@mbgower mbgower merged commit 433fdf7 into main May 20, 2025
1 check passed
@mbgower mbgower deleted the patrickhlauke-techniqueG13-tweak branch May 20, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Technique G13 - allows surveys to advance on input with notice, even radio buttons?
8 participants