Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement orientation support for VideoEncoder. #884

Merged
merged 2 commits into from
Mar 14, 2025
Merged

Conversation

dalecurtis
Copy link
Contributor

@dalecurtis dalecurtis commented Mar 13, 2025

This implements the algorithm as discussed in the Media WG:

  • Orientation is locked-in upon the first call to encode().
  • Mismatched orientation will trigger a non-fatal error by throwing an exception during encode().
  • The orientation of the first frame is emitted on the VideoDecoderConfig attached to EncodedVideoChunkMetadata.

Fixes: #351


Preview | Diff

This implements the algorithm as discussed in the Media WG:
* Orientation is locked-in upon the first call to encode().
* Mismatched orientation will trigger a non-fatal error by throwing
  an exception during encode().
* The orientation of the first frame is emitted on the
  VideoDecoderConfig attached to EncodedVideoChunkMetadata.

Fixes: #351
@dalecurtis dalecurtis requested review from Djuffin and padenot March 13, 2025 23:36
@dalecurtis dalecurtis merged commit c683ac1 into main Mar 14, 2025
2 checks passed
@dalecurtis dalecurtis deleted the orientation branch March 14, 2025 19:03
github-actions bot added a commit that referenced this pull request Mar 14, 2025
SHA: c683ac1
Reason: push, by dalecurtis

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orientation metadata for VideoFrame
3 participants