Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add receiveTime field to RTCEncodedVideoFrameMetadata and RTCEncodedAudioFrame #237

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

guidou
Copy link
Collaborator

@guidou guidou commented Feb 3, 2025

Drive-by: Fix bugs preventing proper translation of the spec.


Preview | Diff

@guidou guidou requested review from aboba, youennf and jan-ivar February 3, 2025 09:47
Copy link
Collaborator

@youennf youennf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it clear that it only exists for incoming frames, like for other fields.

index.bs Outdated
@@ -565,6 +572,11 @@ interface RTCEncodedVideoFrame {
</tr>
</tbody>
</table>
<p class="note">
Since packetizers may drop certain elements, e.g. AV1 temporal delimiter OBUs,
the input to an receive-side transform may be different from the output of

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi folks, this is just a small grammar thing. This should read "to a receive-side" instead of "an".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in a separate PR since this doesn't affect this one.

@guidou guidou force-pushed the guidou/receive-time branch 2 times, most recently from 2aadcd3 to 6fb13b6 Compare February 20, 2025 13:41
…udioFrameMetadata

Drive-by: Fix bugs preventing proper translation of the spec.
@guidou guidou force-pushed the guidou/receive-time branch from 6fb13b6 to 61bf6ef Compare February 20, 2025 13:45
@guidou
Copy link
Collaborator Author

guidou commented Feb 24, 2025

Let's make it clear that it only exists for incoming frames, like for other fields.

Done.

@guidou guidou merged commit 7ca5d12 into w3c:main Feb 24, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request Feb 24, 2025
SHA: 7ca5d12
Reason: push, by guidou

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants