-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add receiveTime field to RTCEncodedVideoFrameMetadata and RTCEncodedAudioFrame #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make it clear that it only exists for incoming frames, like for other fields.
index.bs
Outdated
@@ -565,6 +572,11 @@ interface RTCEncodedVideoFrame { | |||
</tr> | |||
</tbody> | |||
</table> | |||
<p class="note"> | |||
Since packetizers may drop certain elements, e.g. AV1 temporal delimiter OBUs, | |||
the input to an receive-side transform may be different from the output of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi folks, this is just a small grammar thing. This should read "to a receive-side" instead of "an".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix in a separate PR since this doesn't affect this one.
2aadcd3
to
6fb13b6
Compare
…udioFrameMetadata Drive-by: Fix bugs preventing proper translation of the spec.
6fb13b6
to
61bf6ef
Compare
Done. |
SHA: 7ca5d12 Reason: push, by guidou Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Drive-by: Fix bugs preventing proper translation of the spec.
Preview | Diff