update waw:workbench:open to default to the active connection's api version #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to api 46
amphro
reviewed
Aug 20, 2019
add in conn version to pull dynamically from the connection
dmgerow
changed the title
dmgerow
commented
Aug 21, 2019
amphro
approved these changes
Aug 21, 2019
Collaborator
amphro
left a comment
amphro
left a comment
There was a problem hiding this comment.
I'm not really sure what kind of tests are set up. It would be nice to have one but assuming you at least ran them? I'll leave that part to Wade =)
Author
|
@amphro I was having trouble linking the plugin locally to test but I am happy to if you have any guidance on how to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make default API version for opening workbench the active connection's api version