Add tests for page creation and rendering with StreamField #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thibaudcolas
left a comment
thibaudcolas
left a comment
There was a problem hiding this comment.
Looking really solid! I’m not familiar with those APIs myself so will need to compare with the docs side-by-side before I do further review / merging.
Two changes I’d like to see as follow-up:
- Run the tests via the Makefile
- Run the tests in CI
Comment on lines
76
to
77
| # Alternative: Use Wagtail's built-in assertion | ||
| self.assertPageIsRoutable(self.home) |
Member
There was a problem hiding this comment.
Not needed for a page type that doesn’t implement RoutablePageMixin
thibaudcolas
force-pushed
the
feature/534-add-demo-test
branch
from
98598ae to
0f71252
Compare
thibaudcolas
force-pushed
the
feature/534-add-demo-test
branch
from
0f71252 to
cf0c8c5
Compare
Co-authored-by: Lupyana <[email protected]>
Co-authored-by: Lupyana <[email protected]>
thibaudcolas
force-pushed
the
feature/534-add-demo-test
branch
from
cf0c8c5 to
b75666d
Compare
thibaudcolas
approved these changes
Jan 9, 2026
Member
thibaudcolas
left a comment
thibaudcolas
left a comment
There was a problem hiding this comment.
I ended up adding the CI setup to have a stronger guarantee this all works and will keep working, merging now!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added example tests demonstrating the creation of a new child page (using a StreamField in form data) and the rendering of a page. The tests use the following assertions:
see #534